From: Tom Lane <tgl@sss.pgh.pa.us>
To: pkopylov@cloudlinux.com
cc: pgsql-bugs@lists.postgresql.org, Nathan Bossart <nathandbossart@gmail.com>
Subject: Re: BUG #19718: pg_dump -Ft: restore.sql gets "\unrestrict
 (null)"/"\restrict (null)", so psql skips \i data files
In-reply-to: <19718-7e945d0ff9b5a589@postgresql.org>
References: <19718-7e945d0ff9b5a589@postgresql.org>
Comments: In-reply-to PG Bug reporting form <noreply@postgresql.org>
	message dated "Thu, 24 Sep 2026 21:24:46 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <13362.1790440804.1@sss.pgh.pa.us>
Date: Sat, 26 Sep 2026 12:40:04 -0400
Message-ID: <13363.1790440804@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/13363.1790440804%40sss.pgh.pa.us>
Precedence: bulk

PG Bug reporting form <noreply@postgresql.org> writes:
> Since commit 71ea0d6795 ("Restrict psql meta-commands in plain-text dumps"),
> _reconnectToDB() in src/bin/pg_dump/pg_backup_archiver.c writes

>       ahprintf(AH, "\\unrestrict %s\n", ropt->restrict_key);
>       ...
>       ahprintf(AH, "\\restrict %s\n\n", ropt->restrict_key);

> without checking ropt->restrict_key.

Yeah, that's bad.  It's not surprising that nobody noticed for
tar-format "restore.sql" files, because those are pretty much
write-only; I don't know of any tool that uses them.  I wonder
though if there's any other way to reach this ...

			regards, tom lane