Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1v9D5z-00CYFS-Nd
	for pgsql-bugs@arkaria.postgresql.org; Thu, 16 Oct 2025 01:47:59 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1v9D5x-009Jcn-Er
	for pgsql-bugs@arkaria.postgresql.org; Thu, 16 Oct 2025 01:47:56 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1v9D5x-009JcV-5K
	for pgsql-bugs@lists.postgresql.org; Thu, 16 Oct 2025 01:47:56 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1v9D5u-0020IZ-1R
	for pgsql-bugs@lists.postgresql.org;
	Thu, 16 Oct 2025 01:47:55 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 59G1lqBu1349120;
	Wed, 15 Oct 2025 21:47:52 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
cc: Nathan Bossart <nathandbossart@gmail.com>, andrewbille@gmail.com,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19086: pg_dump --data-only selects and do not uses index
 definitions for the dumped tables.
In-reply-to: 
 <CAApHDvrNozFw_K2cbe5oLmxt0VSbU5yweKxvybAvnHt+K_MAaA@mail.gmail.com>
References: <19086-871ff11017d03dc5@postgresql.org> <aO6mUj9H2WpEFylG@nathan>
 <1000041.1760471415@sss.pgh.pa.us> <aO7IoIEnQDbtFzrs@nathan>
 <CAApHDvoU2O-_zKNL-toHwkDcMXCzzvgRUTnA3baEEhCB4vqMRw@mail.gmail.com>
 <aO_KwnHm2AVn0E4m@nathan>
 <CAApHDvrcM4G0==52jFoAvmxk6ZRjXKq7nkik=fqq6BH=dSJsYA@mail.gmail.com>
 <1324003.1760565328@sss.pgh.pa.us>
 <CAApHDvrffhKALh3jQM6Kmar5nt=2xgHC_0ErhTFvM32b_JT-Cw@mail.gmail.com>
 <1334977.1760571380@sss.pgh.pa.us>
 <CAApHDvp-BsfUne0TckE5f8-E9Ou3+2+fT0aN2OB+ccC88zy-yQ@mail.gmail.com>
 <1342348.1760575547@sss.pgh.pa.us>
 <CAApHDvoMvU2=bDKLDZq1y4FM7k5FsOgogsiqJ3gaJ+G8yLTq-A@mail.gmail.com>
 <1347707.1760578289@sss.pgh.pa.us>
 <CAApHDvrNozFw_K2cbe5oLmxt0VSbU5yweKxvybAvnHt+K_MAaA@mail.gmail.com>
Comments: In-reply-to David Rowley <dgrowleyml@gmail.com>
	message dated "Thu, 16 Oct 2025 14:36:23 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1349118.1760579272.1@sss.pgh.pa.us>
Date: Wed, 15 Oct 2025 21:47:52 -0400
Message-ID: <1349119.1760579272@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Archived-At: 
 <https://www.postgresql.org/message-id/1349119.1760579272%40sss.pgh.pa.us>
Precedence: bulk

David Rowley <dgrowleyml@gmail.com> writes:
> On Thu, 16 Oct 2025 at 14:31, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I'm confused by all the extraneous changes in this?

> It includes the query rewrite too in order to get rid of the
> subqueries in the targetlist to pg_attribute.

Ah, I've not reviewed that bit.

> We could just do the conditional calling of
> the pg_get_*def() functions, but performance would still be terrible
> for ignore_system_indexes=on due to the Seq Scans, and slightly worse
> overall.

Got it.  Definitely looks promising, but I'm too tired to review
the whole change.

			regards, tom lane