From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Watkins <awatkins1966@gmail.com>
cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18995: Building with GCC 14 fails: incompatible pointer
 struct pam_message
In-reply-to: <1341739.1753296062@sss.pgh.pa.us>
References: <18995-82058da9ab4337a7@postgresql.org>
 <1313566.1753280855@sss.pgh.pa.us>
 <CAH5VfSHUdo1-OPtTn2rbr6LK9eYOtPpjh0=ctNiEMQmYL7BpPw@mail.gmail.com>
 <1341739.1753296062@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Wed, 23 Jul 2025 14:41:02 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1358970.1753300026.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 23 Jul 2025 15:47:06 -0400
Message-ID: <1358971.1753300026@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1358971.1753300026%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> I still see a way to avoid a configure check though: let's make
> src/include/port/solaris.h "#define _PAM_LEGACY_NONCONST".
> That should make OpenIndiana enough like other Solaris-alikes
> for the purpose, and we can also use that same symbol to cue
> our code how to declare the callback function.

Done that way at

https://git.postgresql.org/gitweb/?p=3Dpostgresql.git;a=3Dpatch;h=3D635a85=
6279ef55074dfc7a2a96c7fd686b5ff015

If you can confirm that you get a clean build with this patch,
I'd appreciate it.

			regards, tom lane