From: Tom Lane <tgl@sss.pgh.pa.us>
To: Changqing Li <changqing.li@windriver.com>
cc: pgsql-bugs@lists.postgresql.org,
        Changqing Li <changqing.li@eng.windriver.com>
Subject: Re: A build failure since only include header
 "postgresql/server/port.h"
In-reply-to: <ab31fa66-face-4866-8e2f-b947f4ba42a6@windriver.com>
References: <ab31fa66-face-4866-8e2f-b947f4ba42a6@windriver.com>
Comments: In-reply-to Changqing Li <changqing.li@windriver.com>
	message dated "Wed, 06 Mar 2024 16:51:41 +0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <136933.1709738306.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Wed, 06 Mar 2024 10:18:26 -0500
Message-ID: <136934.1709738306@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/136934.1709738306%40sss.pgh.pa.us>
Precedence: bulk

Changqing Li <changqing.li@windriver.com> writes:
> SIGNAL_ARGS is used in port.h, it is defined in c.h,  But port.h don't 
> include c.h, and cause above error.   Should we include c.h in port.h?

No, absolutely not.  The expectation in all PG header files is that
the .c file included one of postgres.h, postgres_fe.h, or c.h to
begin with (mainly to establish whether this file is backend code,
frontend code, or intended to work as both).  This is your error
not port.h's.

			regards, tom lane