pg.ddx.io pgsql-bugs@postgresql.org mailing list archive
help / color / mirror / Atom feedServer crash when selecting from pg_cursors
2+ messages / 2 participants
[nested] [flat]
Commits from this thread:
2024-10-06 f8d9a9f21e 5c17f5a639 4a17acd0db 3daeb539a6 5de77b609c aef75219cc 3922c9e9f3 Ignore not-yet-defined Portals in pg_cursors view.
* Server crash when selecting from pg_cursors
@ 2024-10-06 16:15 PetSerAl <petseral@gmail.com>
0 siblings, 1 reply; 2+ messages in thread
From: PetSerAl @ 2024-10-06 16:15 UTC (permalink / raw)
To: pgsql-bugs@lists.postgresql.org
postgres=# SELECT version();
version
-------------------------------------------------------------------------
PostgreSQL 17.0 on x86_64-windows, compiled by msvc-19.41.34120, 64-bit
(1 row)
postgres=# CREATE TABLE t (a integer, b integer);
CREATE TABLE
postgres=# CREATE FUNCTION f() RETURNS integer
postgres-# STABLE STRICT LANGUAGE plpgsql
postgres-# AS $$
postgres$# BEGIN
postgres$# PERFORM FROM pg_cursors;
postgres$# RETURN null;
postgres$# END
postgres$# $$;
CREATE FUNCTION
postgres=# DO $$
postgres$# DECLARE
postgres$# a integer;
postgres$# BEGIN
postgres$# FOR a IN SELECT t.a FROM t WHERE t.b = f() LOOP
postgres$# END LOOP;
postgres$# END
postgres$# $$;
server closed the connection unexpectedly
This probably means the server terminated abnormally
before or while processing the request.
server closed the connection unexpectedly
This probably means the server terminated abnormally
before or while processing the request.
The connection to the server was lost. Attempting reset: Failed.
The connection to the server was lost. Attempting reset: Failed.
!?>
Server log:
[21932] LOG: server process (PID 22552) was terminated by exception 0xC0000005
[21932] DETAIL: Failed process was running: DO $$
DECLARE
a integer;
BEGIN
FOR a IN SELECT t.a FROM t WHERE t.b = f() LOOP
END LOOP;
END
$$;
[21932] HINT: See C include file "ntstatus.h" for a description of
the hexadecimal value.
[21932] LOG: terminating any other active server processes
[21932] LOG: all server processes terminated; reinitializing
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: Server crash when selecting from pg_cursors
@ 2024-10-06 18:08 Tom Lane <tgl@sss.pgh.pa.us>
parent: PetSerAl <petseral@gmail.com>
0 siblings, 0 replies; 2+ messages in thread
From: Tom Lane @ 2024-10-06 18:08 UTC (permalink / raw)
To: PetSerAl <petseral@gmail.com>; +Cc: pgsql-bugs@lists.postgresql.org
PetSerAl <petseral@gmail.com> writes:
> postgres=# CREATE TABLE t (a integer, b integer);
> CREATE TABLE
> postgres=# CREATE FUNCTION f() RETURNS integer
> postgres-# STABLE STRICT LANGUAGE plpgsql
> postgres-# AS $$
> postgres$# BEGIN
> postgres$# PERFORM FROM pg_cursors;
> postgres$# RETURN null;
> postgres$# END
> postgres$# $$;
> CREATE FUNCTION
> postgres=# DO $$
> postgres$# DECLARE
> postgres$# a integer;
> postgres$# BEGIN
> postgres$# FOR a IN SELECT t.a FROM t WHERE t.b = f() LOOP
> postgres$# END LOOP;
> postgres$# END
> postgres$# $$;
> server closed the connection unexpectedly
Huh, nice one. It's not new in v17 though --- it seems quite ancient.
The proximate cause is that pg_cursor() is assuming portal->sourceText
can't be NULL:
values[1] = CStringGetTextDatum(portal->sourceText);
which is not unreasonable considering that portal.h quoth
const char *sourceText; /* text of query (as of 8.4, never NULL) */
But there's a problem: we may be examining a portal that has been
added to the portal hashtable, but for which PortalDefineQuery
hasn't been called yet.
There are a few ways we might try to deal with this, but I think
the most reasonable one is to make pg_cursor() ignore portals
that haven't been defined yet, as attached.
regards, tom lane
Attachments:
harden-pg_cursor-against-null-sourceText.patch (text/x-diff, 548B) download
diff --git a/src/backend/utils/mmgr/portalmem.c b/src/backend/utils/mmgr/portalmem.c
index 4a24613537..93137820ac 100644
--- a/src/backend/utils/mmgr/portalmem.c
+++ b/src/backend/utils/mmgr/portalmem.c
@@ -1150,6 +1150,9 @@ pg_cursor(PG_FUNCTION_ARGS)
/* report only "visible" entries */
if (!portal->visible)
continue;
+ /* also ignore it if PortalDefineQuery hasn't been called yet */
+ if (!portal->sourceText)
+ continue;
values[0] = CStringGetTextDatum(portal->name);
values[1] = CStringGetTextDatum(portal->sourceText);
end of thread, other threads:[~2024-10-06 18:08 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-10-06 16:15 Server crash when selecting from pg_cursors PetSerAl <petseral@gmail.com>
2024-10-06 18:08 ` Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox