Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xO4oW-00000002uHU-0tH1 for pgsql-bugs@arkaria.postgresql.org; Tue, 03 Nov 2026 03:03:57 +0000 Received: from localhost ([127.0.0.1]:35500 helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xO4oT-000000077Ej-1qb6 for pgsql-bugs@arkaria.postgresql.org; Tue, 03 Nov 2026 03:03:53 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]:49586) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xO4oT-000000077Eb-0lIq for pgsql-bugs@lists.postgresql.org; Tue, 03 Nov 2026 03:03:53 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xO4oP-00000002L49-2lSl for pgsql-bugs@lists.postgresql.org; Tue, 03 Nov 2026 03:03:52 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.18.1/8.18.1) with ESMTP id 6A333lxw1382079; Mon, 2 Nov 2026 22:03:47 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 sss.pgh.pa.us 6A333lxw1382079 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sss.pgh.pa.us; s=default; t=1793675027; bh=1v/mcMVDAtHR2m5N3Hj6h8awb2Y8FLHXnIb0AKiM5XQ=; h=From:To:cc:Subject:In-reply-to:References:Date:From; b=1PhJhS+UVlarh1z5TwcMW0nIcieFaRDHW1fY9xXChWQEqcCPNmnbIypdJPl5JBFVg uSp4+WmevsOvxtb6gKSDYR/BHb23nRGtG1S2H34wo67s8OiyYrFapZpHAbPq6y9ELr gzn4BhaE4qbaY70yQcBlC52Jddybd3d7WlkVw9uI= From: Tom Lane To: Venu K cc: pgsql-bugs@lists.postgresql.org Subject: Re: BUG #19826: corr()/regr_r2() of constant input: NULL serially, 1 with partial aggregation In-reply-to: References: <19826-4b769cb5342fdfe7@postgresql.org> Comments: In-reply-to Venu K message dated "Mon, 02 Nov 2026 21:09:37 +0530" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1382077.1793675027.1@sss.pgh.pa.us> Date: Mon, 02 Nov 2026 22:03:47 -0500 Message-ID: <1382078.1793675027@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Venu K writes: > Attached is a patch for master. Hm, the actual bug report hasn't come through yet, but I gather your point is that float8_regr_combine hasn't gotten the word about the efforts we've made in float8_regr_accum to avoid roundoff error for all-the-same inputs. Good point, but isn't it also missing the latter routine's recently-added logic for forcing outputs to NaN when necessary? Also, TBH, the proposed comments read like AI slop; they don't address any of the questions I had on first reading the patch. Some more effort seems appropriate there. regards, tom lane