From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrei Lepikhov <lepihov@gmail.com>
cc: Richard Guo <guofenglinux@gmail.com>, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18576: Using EXPLAIN (VERBOSE) in
 information_schema.element_types returns ERROR: failed to find plan for
In-reply-to: <332f0e30-f90a-4e47-b668-b53f649c244f@gmail.com>
References: <18576-9feac34e132fea9e@postgresql.org>
 <CAMbWs49gOeyotM7riJ-q_NgLgfA6-3z7DffnR71kSyaHTkh2ig@mail.gmail.com>
 <2336091.1723137115@sss.pgh.pa.us> <2493069.1723149304@sss.pgh.pa.us>
 <CAMbWs4_Au2i+p2MbZ8nNB_QQXrFy65CXNeJL11j2WJbNW18fHQ@mail.gmail.com>
 <2548861.1723174234@sss.pgh.pa.us> <2799439.1723217127@sss.pgh.pa.us>
 <332f0e30-f90a-4e47-b668-b53f649c244f@gmail.com>
Comments: In-reply-to Andrei Lepikhov <lepihov@gmail.com>
	message dated "Mon, 19 Aug 2024 13:23:51 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1385301.1724085401.1@sss.pgh.pa.us>
Date: Mon, 19 Aug 2024 12:36:41 -0400
Message-ID: <1385302.1724085401@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1385302.1724085401%40sss.pgh.pa.us>
Precedence: bulk

Andrei Lepikhov <lepihov@gmail.com> writes:
> Thanks for pushing this!

> But could you change this code a little bit?
> I reported this issue a year ago. At that time, it was triggered by the 
> CustomScan node [1]. I haven't found the solution there [2]. Your code 
> looks like a good tradeoff, and if you slightly change the code (like in 
> the attachment), it allows CustomScan to survive such cases.

This seems like it's making assumptions it shouldn't about what
CustomScan does.  If there's an argument for doing this, it should
be added to the adjacent comments.

(Also, what's with the random change in contrib/Makefile?)

			regards, tom lane