From: Tom Lane <tgl@sss.pgh.pa.us>
To: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
cc: Michael Paquier <michael@paquier.xyz>, exclusion@gmail.com,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18984: Empty prepared statement from psql \parse triggers
 assert in PortalRunMulti
In-reply-to: <1400898.1752759934@sss.pgh.pa.us>
References: <202507171203.y6yp2n25fk6f@alvherre.pgsql>
 <1400898.1752759934@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Thu, 17 Jul 2025 09:45:34 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1409148.1752764456.1@sss.pgh.pa.us>
Date: Thu, 17 Jul 2025 11:00:56 -0400
Message-ID: <1409149.1752764456@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1409149.1752764456%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de> writes:

> I think that where the Portal gets a tag is in PortalDefineQuery,
> and that's normally set as a result of parsing.

So rather than using the word "default", maybe like

    * If a command tag was requested and we did not fill in a
    * run-time-determined tag above, copy the parse-time tag
    * from the Portal.  (There might not be any tag there either,
    * in edge cases such as empty prepared statements.  That's OK.)

			regards, tom lane