Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1pW2Ue-00072o-18
	for pgsql-bugs@arkaria.postgresql.org; Sat, 25 Feb 2023 21:54:12 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1pW2Uc-00079j-PW
	for pgsql-bugs@arkaria.postgresql.org; Sat, 25 Feb 2023 21:54:10 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1pW2Uc-00079a-HI
	for pgsql-bugs@lists.postgresql.org; Sat, 25 Feb 2023 21:54:10 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1pW2Ua-0003Ey-0M
	for pgsql-bugs@lists.postgresql.org; Sat, 25 Feb 2023 21:54:10 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 31PLs3ZO1421845;
	Sat, 25 Feb 2023 16:54:03 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Michael Paquier <michael@paquier.xyz>, exclusion@gmail.com,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17800: ON CONFLICT DO UPDATE fails to detect incompatible
 fields that leads to a server crash
In-reply-to: <20230225214607.srx2l7yar2clgku6@awork3.anarazel.de>
References: <20230222011705.sv75mkhvmxuqv22l@awork3.anarazel.de>
 <20230222192350.wviaslfpo3w2ja3l@awork3.anarazel.de>
 <290812.1677101054@sss.pgh.pa.us> <586533.1677178414@sss.pgh.pa.us>
 <20230223210012.4qigvo6sryn2syu5@awork3.anarazel.de>
 <718944.1677189963@sss.pgh.pa.us>
 <20230223233636.zkt4tqzsc4b6ekwn@awork3.anarazel.de>
 <20230224015417.75yimxbksejpffh3@awork3.anarazel.de>
 <851179.1677259566@sss.pgh.pa.us>
 <20230224174412.xk3y364t6a2udp5t@awork3.anarazel.de>
 <20230225214607.srx2l7yar2clgku6@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Sat, 25 Feb 2023 13:46:07 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1421843.1677362043.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sat, 25 Feb 2023 16:54:03 -0500
Message-ID: <1421844.1677362043@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Archived-At: 
 <https://www.postgresql.org/message-id/1421844.1677362043%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2023-02-24 09:44:12 -0800, Andres Freund wrote:
>> I'd happy if you had a go at it.  I might take a stab at moving the the
>> argument evaluation inline, after this goes in.

> Turned out to be pretty simple (at least for now, we'll see what I misse=
d):
> https://www.postgresql.org/message-id/20230225214401.346ancgjqc3zmvek%40=
awork3.anarazel.de

Looks plausible in a very quick once-over.  If you want to add it to
the upcoming CF, I'll do a more careful review later (or somebody
else can).

			regards, tom lane