From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        Euler Taveira <euler@eulerto.com>, chenjq.jy@fujitsu.com,
        pgsql-bugs@lists.postgresql.org, Julien Rouhaud <rjuju123@gmail.com>
Subject: Re: BUG #17148: About --no-strict-names option and --quiet option of
 pg_amcheck command
In-reply-to: <53F68B28-4FDB-4AC9-882C-A620D3389EB0@yesql.se>
References: <17148-b5087318e2b04fc6@postgresql.org>
 <B9A9C944-9EAC-421C-8044-EF109ADAC4D4@yesql.se>
 <A6A434CC-AA6D-4DD2-A26E-B6E226CCAD9B@yesql.se>
 <fb17eac7-f5cf-4e6f-9b67-f5fb4855d1d9@www.fastmail.com>
 <F5A1A42D-184C-46B7-8FBF-17AA000D28E0@yesql.se>
 <429f6e0e-31eb-4741-8bf8-e9e827b3076d@www.fastmail.com>
 <acde4807-7cd4-2c15-b73a-ac8e71c71191@enterprisedb.com>
 <53F68B28-4FDB-4AC9-882C-A620D3389EB0@yesql.se>
Comments: In-reply-to Daniel Gustafsson <daniel@yesql.se>
	message dated "Wed, 18 Aug 2021 14:35:06 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1426270.1629294170.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 18 Aug 2021 09:42:50 -0400
Message-ID: <1426271.1629294170@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1426271.1629294170%40sss.pgh.pa.us>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:
>> On 18 Aug 2021, at 13:44, Peter Eisentraut <peter.eisentraut@enterprise=
db.com> wrote:
>> I think this both of these things could be deleted and we could get rid=
 of the --quiet option, to simplify all this. =


> It simplifies the pg_amcheck code a bit, but it at the same time complic=
ates
> the tests as they are currently written.  Not sure that we want to chang=
e that
> much as this point in the 14 cycle?

It's going to become much harder to change pg_amcheck's user-visible
behavior once it's shipped in a release.  Better to fix it now while
there are not backwards-compatibility concerns.

			regards, tom lane