From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
cc: =?UTF-8?B?QWxlxaEgWmVsZW7DvQ==?= <zeleny.ales@gmail.com>,
        PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17512: Process running query fails with SIGSEV -
 nodeMemoize.c:349
In-reply-to: 
 <CAApHDvpxFSTwvoYWT7kmFVSZ9zLAeHb=S9vrz=RExMgSkQNWqw@mail.gmail.com>
References: <17512-36fa5fab90f48af9@postgresql.org>
 <CAApHDvqohSVm-QgGyJhq6TB1GSN-UeuWdOaQwHTkL6UVQ3xpsg@mail.gmail.com>
 <CAODqTUatpvf7D0e5cykrqEih6j8cGw7NTRLpZhPAZX6+-Ec94Q@mail.gmail.com>
 <CAODqTUY5DqbnSMxmTB2xWKuOd4Ykg8GEJMPA16jUkPsmx75TrQ@mail.gmail.com>
 <1264308.1654628854@sss.pgh.pa.us>
 <CAApHDvpxFSTwvoYWT7kmFVSZ9zLAeHb=S9vrz=RExMgSkQNWqw@mail.gmail.com>
Comments: In-reply-to David Rowley <dgrowleyml@gmail.com>
	message dated "Wed, 08 Jun 2022 11:39:41 +1200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1432707.1654645381.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 07 Jun 2022 19:43:01 -0400
Message-ID: <1432708.1654645381@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1432708.1654645381%40sss.pgh.pa.us>
Precedence: bulk

David Rowley <dgrowleyml@gmail.com> writes:
> server closed the connection unexpectedly

Ugh.

> If I patch it with the attached rebustify_memoize_code.patch, I get:
> # explain analyze select * from t1 inner join t1 t2 on t1.a=3Dt2.a where=
 t1.a<=3D2;
> ERROR:  unable to find memoization table entry

> My thoughts are that we likely should make this code more robust,
> despite the bug not being related to a broken data type. I'm only just
> over the fence on that one though. Any thoughts?

Strong +1, but please s/unable to/could not/, per message style
guidelines.

			regards, tom lane