From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael.paquier@gmail.com>
cc: Nicolas Barbier <nicolas.barbier@gmail.com>,
        PostgreSQL Bugs <pgsql-bugs@postgresql.org>
Subject: Re: \copy produces CSV output that cannot be read by \copy
In-reply-to: 
 <CAB7nPqQvFQz=C2q8aTs5YGRe==796EwnjcmjXmW4J4McZUF8Ow@mail.gmail.com>
References: 
 <CAP-rdTbO35=U0+2Dn-i9FAYvau7Lm6Athd29KZ4sS+kDs21tLg@mail.gmail.com>
 <CAB7nPqQvFQz=C2q8aTs5YGRe==796EwnjcmjXmW4J4McZUF8Ow@mail.gmail.com>
Comments: In-reply-to Michael Paquier <michael.paquier@gmail.com>
	message dated "Sat, 05 Aug 2017 18:39:19 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1472.1501951948.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sat, 05 Aug 2017 12:52:28 -0400
Message-ID: <1473.1501951948@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-bugs-owner@postgresql.org

Michael Paquier <michael.paquier@gmail.com> writes:
> The format produced by COPY OUT looks fine to me, and can be reloaded
> with a plain COPY (not \copy). And you may be interested in this bit
> from src/bin/psql/copy.c:
>                     /*
>                      * This code erroneously assumes '\.' on a line alone
>                      * inside a quoted CSV string terminates the \copy.
>                      *
> http://www.postgresql.org/message-id/E1TdNVQ-0001ju-GO@wrigleys.postgresq=
l.org
>                      */

I wonder if it would improve matters to check for "\." only when
copystream =3D=3D pset.cur_cmd_source, that is, only when the copy data
is inlined into the SQL stream.  That would create an inconsistency
between inline and out-of-line data, but it might be a reasonable
thing to do anyway.

			regards, tom lane


--=20
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs