Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xT4cM-000000005Hl-1fHd for pgsql-bugs@arkaria.postgresql.org; Mon, 16 Nov 2026 21:52:02 +0000 Received: from localhost ([127.0.0.1]:41978 helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xT4cL-00000001LoZ-3YER for pgsql-bugs@arkaria.postgresql.org; Mon, 16 Nov 2026 21:52:01 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]:45540) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xT4cL-00000001LoR-2aOB for pgsql-bugs@lists.postgresql.org; Mon, 16 Nov 2026 21:52:01 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xT4cJ-000000002oy-2OOj for pgsql-bugs@lists.postgresql.org; Mon, 16 Nov 2026 21:52:00 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.18.1/8.18.1) with ESMTP id 6AGLpwOD148734; Mon, 16 Nov 2026 16:51:58 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 sss.pgh.pa.us 6AGLpwOD148734 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sss.pgh.pa.us; s=default; t=1794865918; bh=IIeQffVh03XTJI4VfV/JWAwCMxn9q8xahoBaAbX6Si4=; h=From:To:cc:Subject:In-reply-to:References:Date:From; b=VV2LVt6IiPrWxABvO3fGsFL9KTZHlzM/OQ0vBi8AJ/tYy85ODNd4Mu+V8Un6gna3Z 7Jf59eAzl2gxsq9MJzUb9gjxAWPSd3hVPwYL57/b92W18SOKvGKvX7byunl48BIwW3 NLUohsrcbFSXFbwPDx/O9VcVZRrvu3CcrQrPjth8= From: Tom Lane To: Robert Haas cc: schefner20@gmail.com, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #19908: pg_upgrade --check crashes instance if running in a different PID Namespace then the old cluster In-reply-to: References: <19908-3db6f3c4f2febdcf@postgresql.org> <145931.1794861628@sss.pgh.pa.us> Comments: In-reply-to Robert Haas message dated "Mon, 16 Nov 2026 16:36:55 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <148732.1794865918.1@sss.pgh.pa.us> Date: Mon, 16 Nov 2026 16:51:58 -0500 Message-ID: <148733.1794865918@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Robert Haas writes: > I also feel like it's counterintuitive that pg_upgrade --check can > destroy data, regardless of anything else. One could certainly fail to > read the documentation and fail to realize that risk. Perhaps it'd be reasonable for --check mode to not risk a start_postmaster() action, but just bail out if it sees a postmaster.pid file. However, that doesn't do diddly-squat for what I consider the real hazard here: the described environment breaks our safeguards against starting two postmasters in the same data directory. That WILL eat your data someday, and there's nothing we can do to prevent it. regards, tom lane