From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Sergei Kornilov <sk@zsrv.org>, pgsql-hackers@postgresql.org,
        Peter Eisentraut <peter_e@gmx.net>,
 Marc Dean <marc.dean.jr@gmail.com>,
        Petr Jelinek <petr@2ndquadrant.com>,
        "michael.paul.powers@gmail.com" <michael.paul.powers@gmail.com>,
        "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #15293: Stored Procedure Triggered by Logical Replication is
 Unable to use Notification Events
In-reply-to: <20180724215604.hwl4xk2v4ulkgvwk@alap3.anarazel.de>
References: <153243441449.1404.2274116228506175596@wrigleys.postgresql.org>
 <45136061532438385@iva3-a2a8aac410a1.qloud-c.yandex.net>
 <20180724155829.zq22vov6d7erhxsx@alap3.anarazel.de>
 <CAEU75wAdO7_t6MzSqWxua4Cca+KKpuHYYz6txz=VgETX--yYvw@mail.gmail.com>
 <648481532456538@myt5-0fa3e541b8b9.qloud-c.yandex.net>
 <20180724192740.6yn2xregaz6yhpc2@alap3.anarazel.de>
 <13844.1532468610@sss.pgh.pa.us>
 <20180724215604.hwl4xk2v4ulkgvwk@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Tue, 24 Jul 2018 14:56:04 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <14886.1532469693.1@sss.pgh.pa.us>
Date: Tue, 24 Jul 2018 18:01:33 -0400
Message-ID: <14887.1532469693@sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> One other thing, somewhat independent, I wonder is if it's actually
> problematic that we don't do ProcessCompletedNotifies() in a bunch of
> processes, because that means we'll not necessarily call
> asyncQueueAdvanceTail().  Perhaps that means we actually *do* need to do
> it around CommitTransactionCommand()?

As far as that goes, we should probably ensure that a process that hasn't
executed any LISTENs is ignored for purposes of whether to advance the
queue tail.  I think it might be like that already.

			regards, tom lane