From: Tom Lane <tgl@sss.pgh.pa.us>
To: andrewbille@gmail.com
cc: pgsql-bugs@lists.postgresql.org, Daniel Gustafsson <daniel@yesql.se>
Subject: Re: BUG #17346: pg_upgrade fails with role granted by other role
In-reply-to: <17346-f72b28bd1a341060@postgresql.org>
References: <17346-f72b28bd1a341060@postgresql.org>
Comments: In-reply-to PG Bug reporting form <noreply@postgresql.org>
	message dated "Mon, 27 Dec 2021 08:38:17 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1489047.1640620947.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 27 Dec 2021 11:02:27 -0500
Message-ID: <1489048.1640620947@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1489048.1640620947%40sss.pgh.pa.us>
Precedence: bulk

PG Bug reporting form <noreply@postgresql.org> writes:
> After the commit:

> commit 371087d006e04991080bf17cf2287db38d3ea92e
> Author: Daniel Gustafsson <dgustafsson@postgresql.org>
> Date:   Fri Nov 26 14:02:01 2021 +0100
>     Fix GRANTED BY support in REVOKE ROLE statements
    =

> pg_upgrade for example from 10.19 version causes the error:

Yeah, you don't even need pg_upgrade.  Just do

regression=3D# CREATE ROLE user1; CREATE ROLE user2; GRANT user1 TO user2 =
GRANTED BY user1;
CREATE ROLE
CREATE ROLE
ERROR:  grantor must be current user

A superuser, or really anyone who's a member of the user1 role,
ought to be able to do that (especially since it used to be allowed).
So it seems the permissions check was coded incorrectly.

			regards, tom lane