Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHs7Y-0007xz-Ta for pgsql-bugs@arkaria.postgresql.org; Mon, 05 Jun 2017 13:32:37 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dHs7Y-0000s6-Fs for pgsql-bugs@arkaria.postgresql.org; Mon, 05 Jun 2017 13:32:36 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dHqFE-0001FC-JZ for pgsql-bugs@postgresql.org; Mon, 05 Jun 2017 11:32:24 +0000 Received: from mwork.nabble.com ([162.253.133.43]) by makus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHqFA-0002C7-2i for pgsql-bugs@postgresql.org; Mon, 05 Jun 2017 11:32:23 +0000 Received: from mben.nabble.com (unknown [162.253.133.72]) by mwork.nabble.com (Postfix) with ESMTP id 8F1CB477C65E2 for ; Mon, 5 Jun 2017 04:32:17 -0700 (MST) Date: Mon, 5 Jun 2017 04:32:17 -0700 (MST) From: wangchuanting To: pgsql-bugs@postgresql.org Message-ID: <1496662337584-5964796.post@n3.nabble.com> In-Reply-To: References: <20170531033228.1487.10124@wrigleys.postgresql.org> <28851.1496239047@sss.pgh.pa.us> <1496368772770-5964407.post@n3.nabble.com> Subject: Re: BUG #14680: startup process on standby encounter a deadlock of TwoPhaseStateLock when redo 2PC xlog MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -1.2 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-bugs Precedence: bulk Sender: pgsql-bugs-owner@postgresql.org Hi, Michael I don't understand why the patch remove TwoPhaseStateLock in MarkAsPrepared. if so: 1. does it need remove lock acquire in MarkAsPreparing also? 2. MarkAsPrepared will call ProcArrayAdd, and in ProcArrayAdd it acquires ProcArrayLock, we should carefully handle the lock sequence about these two locks. -- View this message in context: http://www.postgresql-archive.org/BUG-14680-startup-process-on-standby-encounter-a-deadlock-of-TwoPhaseStateLock-when-redo-2PC-xlog-tp5964069p5964796.html Sent from the PostgreSQL - bugs mailing list archive at Nabble.com. -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs