From: Tom Lane <tgl@sss.pgh.pa.us>
To: "David G. Johnston" <david.g.johnston@gmail.com>
cc: loren@paradigm.xyz, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17626: Permission denied errors should list role as well as
 user
In-reply-to: 
 <CAKFQuwa9HccMHPkdKnhcJouVXxCwcSnmGybfpDcWw3UFv2Bm7Q@mail.gmail.com>
References: <17626-644f053cc20e1ba3@postgresql.org>
 <1425128.1664805055@sss.pgh.pa.us>
 <CAKFQuwa9HccMHPkdKnhcJouVXxCwcSnmGybfpDcWw3UFv2Bm7Q@mail.gmail.com>
Comments: In-reply-to "David G. Johnston" <david.g.johnston@gmail.com>
	message dated "Mon, 03 Oct 2022 08:40:05 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1515819.1664812411.1@sss.pgh.pa.us>
Date: Mon, 03 Oct 2022 11:53:31 -0400
Message-ID: <1515820.1664812411@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1515820.1664812411%40sss.pgh.pa.us>
Precedence: bulk

"David G. Johnston" <david.g.johnston@gmail.com> writes:
> Basically, a permission check requires two things and the complaint is that
> only one of those things is mentioned in the error message.

No, the complaint is that the wrong thing is shown --- but I don't
know what's showing it; aclcheck_error() certainly doesn't.

There's a separate conversation to be had perhaps about whether
aclcheck_error's standard message *should* include the role name
whose permissions were checked.  I have a vague feeling that that
omission was intentional, but it was so long ago that I don't
recall for sure.  It seems like something that'd be good to show
in more complicated situations with views, security definer
functions, etc.

			regards, tom lane