From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
cc: victor@magic.io, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15519: Casting float4 into int4 gets the wrong sign instead
 of "integer out of range" error
In-reply-to: <15115.1543017152@sss.pgh.pa.us>
References: <15519-4fc785b483201ff1@postgresql.org>
 <874lc7sb1a.fsf@news-spur.riddles.org.uk> <13162.1543014227@sss.pgh.pa.us>
 <87zhtzqs9o.fsf@news-spur.riddles.org.uk> <15115.1543017152@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Fri, 23 Nov 2018 18:52:32 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <15331.1543017494.1@sss.pgh.pa.us>
Date: Fri, 23 Nov 2018 18:58:14 -0500
Message-ID: <15332.1543017494@sss.pgh.pa.us>
Precedence: bulk

I wrote:
> Andrew Gierth <andrew@tao11.riddles.org.uk> writes:
>> if (num < (float4)INT_MIN || num >= -(float4)INT_MIN || ...

> Meh.  Seems to me that's relying on pretty much the same assumptions
> and throwing in an extra dollop of obscurantism on top.

mmm ... but on the other hand, it means we don't need to write the
test differently depending on whether we think INTxx_MAX will get
rounded.  So that's worth something.

			regards, tom lane