Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVyrf-0003K3-33 for pgsql-bugs@arkaria.postgresql.org; Fri, 23 Oct 2020 15:20:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kVyrd-0003Js-Uv for pgsql-bugs@arkaria.postgresql.org; Fri, 23 Oct 2020 15:20:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVyrd-0003Jl-PB for pgsql-bugs@lists.postgresql.org; Fri, 23 Oct 2020 15:20:21 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVyrb-0007KG-D5 for pgsql-bugs@lists.postgresql.org; Fri, 23 Oct 2020 15:20:21 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 09NFKCtA156588; Fri, 23 Oct 2020 11:20:13 -0400 From: Tom Lane To: Daniel Gustafsson cc: jal@etc.to, PostgreSQL mailing lists , Tomas Vondra Subject: Re: BUG #16683: explain plan format xml produces invalid xml In-reply-to: <90BD07DF-D050-48CE-958E-4B5E5FFCDA37@yesql.se> References: <16683-8005033324ad34e9@postgresql.org> <90BD07DF-D050-48CE-958E-4B5E5FFCDA37@yesql.se> Comments: In-reply-to Daniel Gustafsson message dated "Fri, 23 Oct 2020 13:12:13 +0200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <156586.1603466412.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Fri, 23 Oct 2020 11:20:12 -0400 Message-ID: <156587.1603466412@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Daniel Gustafsson writes: >> On 23 Oct 2020, at 12:26, PG Bug reporting form wrote: >> Sort-Space is incorrectly finished with /Sort-Spaces > Nice catch, it was introduced in the Incremental Sort patch, both for di= sk and > memory type sorts as per the attached (unless the opening of the group w= as > supposed to be "Sort Spaces" but singular seems the right choice here). = Agreed. Will push in a bit. regards, tom lane