Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iWRar-0002La-Uq for pgsql-bugs@arkaria.postgresql.org; Sun, 17 Nov 2019 20:56:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iWRaq-0003Nm-Iw for pgsql-bugs@arkaria.postgresql.org; Sun, 17 Nov 2019 20:56:24 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iWRaq-0003Nf-7j for pgsql-bugs@lists.postgresql.org; Sun, 17 Nov 2019 20:56:24 +0000 Received: from smtp03.optiver.com ([195.246.114.70]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iWRaj-0001h5-3b for pgsql-bugs@lists.postgresql.org; Sun, 17 Nov 2019 20:56:22 +0000 Received: from pps.filterd (smtp03.optiver.com [127.0.0.1]) by smtp03.optiver.com (8.16.0.27/8.16.0.27) with SMTP id xAHKqbxH008884; Sun, 17 Nov 2019 21:56:14 +0100 Received: from opammb0561.comp.optiver.com (opammb0561.comp.optiver.com [10.131.160.1]) by smtp03.optiver.com with ESMTP id 2wa7k80cw4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sun, 17 Nov 2019 21:56:14 +0100 Received: from opammb0561.comp.optiver.com (10.131.160.1) by opammb0561.comp.optiver.com (10.131.160.1) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sun, 17 Nov 2019 21:56:14 +0100 Received: from opammb0561.comp.optiver.com ([fe80::9d46:f4ee:846a:2858]) by opammb0561.comp.optiver.com ([fe80::9d46:f4ee:846a:2858%17]) with mapi id 15.00.1473.003; Sun, 17 Nov 2019 21:56:14 +0100 From: Floris Van Nee To: Tom Lane CC: "pgsql-bugs@lists.postgresql.org" , "Ferdi Smit" , Stephen Frost Subject: Re: incorrect pg_dump output due to not handling dropped roles correctly Thread-Topic: incorrect pg_dump output due to not handling dropped roles correctly Thread-Index: AQHVnYlyaAtOuMqKRk60CwO59fDs3g== Date: Sun, 17 Nov 2019 20:56:13 +0000 Message-ID: <1574024173786.96623@Optiver.com> References: <1573808483712.96817@Optiver.com>,<29913.1573835973@sss.pgh.pa.us> In-Reply-To: <29913.1573835973@sss.pgh.pa.us> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.131.160.182] x-tm-as-product-ver: SMEX-14.0.0.1158-8.5.1020-25050.002 x-tm-as-result: No-10--6.230600-8.000000 x-tmase-matchedrid: 9zTThWtzImvuo96mfIBuopzEHTUOuMX33dCmvEa6IiGoLZarzrrPmZz/ bBwW32ikS23jFwoI7b3xhxzMus4ba7BAQLqGlKiv9VjtTc1fwmBrLj3DxYBIN/wmzX3Lqi2AIJ/ ztDSKSUK8FwRCycX8d4nsa8SDM3Sw/63r0U2g4cdwju9EALAXQuuLFZZYlisfv1l2Uvx6ido7qn MAZEGUXNmzcdRxL+xwKrauXd3MZDWuikCL8VXXTG0DrlnXiCo7uP+0CGbGeGibYyjoHP0/1204p X/LpR5gdGByp+zdaDg= x-tm-as-user-approved-sender: Yes x-tm-as-user-blocked-sender: No x-tmase-result: 10--6.230600-8.000000 x-tmase-version: SMEX-14.0.0.1158-8.5.1020-25050.002 x-tm-snts-smtp: 27498907CDE74FCB9AB300AF7D25E8C00D9F3A0BE6B408CA66504B8B85458CCF2000:8 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-11-17_05:,, signatures=0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk > Yeah, I think that would work. Obviously best to test in a throwaway=0A= > database ...=0A= =0A= Thanks, Tom. Fixed it with that query.=0A= =0A= As for the proper fix, indeed it looks like the 'drop role' needs to be tau= ght to update pg_init_privs.=0A= =0A= -Floris=0A= =0A=