From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fujii Masao <masao.fujii@gmail.com>
cc: jj-zhang25@mails.tsinghua.edu.cn, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19644: byteaout,
 float8out and float4out are marked IMMUTABLE but depend on GUCs
In-reply-to: 
 <CAHGQGwFSh8ZJxVWYMQ5S6pagN_eGuF7eA6GBZ9xY-futHL1hpQ@mail.gmail.com>
References: <19644-d6db3fb5e5ad92f4@postgresql.org>
 <CAHGQGwFPDZ8bMW6adGtAiEmMWQ8hTPCV_1APtoTQ38+2bXXgWA@mail.gmail.com>
 <1306744.1788318959@sss.pgh.pa.us>
 <CAHGQGwFSh8ZJxVWYMQ5S6pagN_eGuF7eA6GBZ9xY-futHL1hpQ@mail.gmail.com>
Comments: In-reply-to Fujii Masao <masao.fujii@gmail.com>
	message dated "Sat, 05 Sep 2026 00:54:17 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <1577101.1788542839.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 04 Sep 2026 13:27:19 -0400
Message-ID: <1577102.1788542839@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1577102.1788542839%40sss.pgh.pa.us>
Precedence: bulk

Fujii Masao <masao.fujii@gmail.com> writes:
> On Wed, Sep 2, 2026 at 12:15=E2=80=AFPM Tom Lane <tgl@sss.pgh.pa.us> wro=
te:
>> I agree with changing this on master, but I see no reason to do
>> anything whatever in the back branches.

> +1. BTW, what about v19? Since it hasn't been released yet, it's OK to
> make this change there, or it's too late even for v19?

It's been wrong for so long that I'm not that rushed to fix it in 19.
We might find that there are consequences to be dealt with, so better
to let the fix settle in master.

> On further review, point_out, ISTM that lseg_out, path_out, box_out, pol=
y_out,
> circle_out, and line_out are marked IMMUTABLE but depend on extra_float_=
digits.
> Similarly, pg_mcv_list_out is marked IMMUTABLE but depends on bytea_outp=
ut.
> Perhaps we should fix these at the same time...

Agreed.

			regards, tom lane