From: Tom Lane <tgl@sss.pgh.pa.us>
To: jazz001319@gmail.com
cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17886: Error disabling user triggers on a partitioned table
In-reply-to: <17886-5406d5d828aa4aa3@postgresql.org>
References: <17886-5406d5d828aa4aa3@postgresql.org>
Comments: In-reply-to PG Bug reporting form <noreply@postgresql.org>
	message dated "Tue, 04 Apr 2023 16:47:33 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1582613.1680632672.1@sss.pgh.pa.us>
Date: Tue, 04 Apr 2023 14:24:32 -0400
Message-ID: <1582614.1680632672@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1582614.1680632672%40sss.pgh.pa.us>
Precedence: bulk

PG Bug reporting form <noreply@postgresql.org> writes:
> result:
> postgres=# alter table public.test DISABLE TRIGGER USER;
> ERROR:  42704: trigger "trigger_test" for table "test_def" does not exist
> LOCATION:  EnableDisableTriggerNew, trigger.c:1658

> Expected Result (Postgresql 15.2 and 14.4 - fine):
> testdb=> alter table public.test DISABLE TRIGGER USER;
> ALTER TABLE

Commit ec0925c22 seems to have been quite snakebit.  I already fixed
a deficiency in it in v15/HEAD, but here we have a different symptom
in the older branches.  What's happening is that EnableDisableTrigger
is ignoring the child trigger because it has tgisinternal set to true
and the command passes skip_system = true.

I'm inclined to think that in the older branches (pre f4566345c)
we need to do

-       if (oldtrig->tgisinternal)
+       if (oldtrig->tgisinternal && !OidIsValid(oldtrig->tgparentid))
        {
            /* system trigger ... ok to process? */

but I've not tested that.  Alvaro, what do you think?

			regards, tom lane