Subject: Re: BUG #14706: Dependencies not recorded properly for base
 types
To: Michael Paquier <michael.paquier@gmail.com>
References: <20170614232259.1424.82774@wrigleys.postgresql.org>
 <22824.1497487336@sss.pgh.pa.us>
 <CAB7nPqTyfyxiG2if30eMPRTx9=dTtBPKrLh2g6tNpa1B4=9LPA@mail.gmail.com>
 <1724.1497502434@sss.pgh.pa.us>
 <CAB7nPqRTpRtypR7gfqYLnmqytC1Xi_=sqnET=YWhSZENrNUz8g@mail.gmail.com>
 <CAB7nPqRUgybqbq-rBcpV_0Pp=YEhAfzxVOc0DoMKp56et4RpNw@mail.gmail.com>
 <91122adb-3afc-a727-c4c9-478175729f56@iki.fi>
 <11135.1497544300@sss.pgh.pa.us>
 <1c07c9a6-b56f-fe67-63a5-6913e78df1f6@iki.fi>
 <CAB7nPqTuRMiJBQC65hg4MZVZeUPo1S9qPQ3sVYLw3+bbpEKQ_Q@mail.gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, khuddleston@pivotal.io,
 PostgreSQL mailing lists <pgsql-bugs@postgresql.org>
From: Heikki Linnakangas <hlinnaka@iki.fi>
Message-ID: <15dde5d7-46db-ff9b-64e1-e240535e9534@iki.fi>
Date: Fri, 16 Jun 2017 11:49:48 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: 
 <CAB7nPqTuRMiJBQC65hg4MZVZeUPo1S9qPQ3sVYLw3+bbpEKQ_Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-bugs-owner@postgresql.org

On 06/16/2017 04:54 AM, Michael Paquier wrote:
> On Fri, Jun 16, 2017 at 1:38 AM, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>> On 06/15/2017 07:31 PM, Tom Lane wrote:
>>>
>>> Heikki Linnakangas <hlinnaka@iki.fi> writes:
>>>>
>>>> Hmm. Strictly speaking there's no need to update the dependency when
>>>> changing opaque into cstring. Because cstring is a pinned type,
>>>> recordDependency will do nothing for it.
>>>
>>>> But in any case, I think it'd be better and simpler to fix the
>>>> dependency in SetFunctionArgType() and SetFunctionReturnType() functions
>>>> themselves. They're the ones that change the type, they ought to be
>>>> responsible for fixing the dependency too. See attached.
>>>
>>> Yeah, Heikki's version looks good to me.
>>>
>>> Heikki, are you going to commit/backpatch this, or do you want me to?
>>
>> I can do it, thanks.
>
> Fine for me. My first quick guess was better than what I coded at the
> end, the idea being to wait after TypeCreate() to get the ObjectAdress
> of the new type.

Ok, committed and backported, thanks!

- Heikki


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs