Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1ot9QD-0000No-5E
	for pgsql-bugs@arkaria.postgresql.org; Thu, 10 Nov 2022 15:24:53 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1ot9QB-0008Rv-T9
	for pgsql-bugs@arkaria.postgresql.org; Thu, 10 Nov 2022 15:24:51 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1ot9QB-0008R8-Kk
	for pgsql-bugs@lists.postgresql.org; Thu, 10 Nov 2022 15:24:51 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1ot9Q6-0005Ir-NY
	for pgsql-bugs@lists.postgresql.org; Thu, 10 Nov 2022 15:24:48 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 2AAFOhW5160519;
	Thu, 10 Nov 2022 10:24:43 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Daisuke Higuchi (Fujitsu)" <higuchi.daisuke@fujitsu.com>
cc: "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17681: Building the REL_12_13 source in Visual Studio 2013
 fails.
In-reply-to: 
 <TYWPR01MB967660F1D712C4A387D6B3F9EC019@TYWPR01MB9676.jpnprd01.prod.outlook.com>
References: <17681-485ba2ec13e7f392@postgresql.org>
 <3969640.1668005050@sss.pgh.pa.us> <3977658.1668008266@sss.pgh.pa.us>
 <TYWPR01MB967660F1D712C4A387D6B3F9EC019@TYWPR01MB9676.jpnprd01.prod.outlook.com>
Comments: In-reply-to "Daisuke Higuchi (Fujitsu)"
 <higuchi.daisuke@fujitsu.com>
	message dated "Thu, 10 Nov 2022 01:27:55 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <160517.1668093883.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 10 Nov 2022 10:24:43 -0500
Message-ID: <160518.1668093883@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Archived-At: 
 <https://www.postgresql.org/message-id/160518.1668093883%40sss.pgh.pa.us>
Precedence: bulk

"Daisuke Higuchi (Fujitsu)" <higuchi.daisuke@fujitsu.com> writes:
>> #if defined(_MSC_VER) && _MSC_VER < 1900   /* pre-VS2015 */
>> #define snprintf(str,size,...) sprintf(str,__VA_ARGS__)
>> #endif
>> in snprintf.c below where it #undef's snprintf.  Could you try that and=
 verify it works for you?

> Thank you! I verified this fix works correctly.
> I confirmed that it succeeded to build the source of REL_12_13 + this fi=
x in Visual Studio 2013.

Excellent.  Fix pushed.

			regards, tom lane