From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
cc: Andres Freund <andres@anarazel.de>, exclusion@gmail.com,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17994: Invalidating relcache corrupts tupDesc inside
 ExecEvalFieldStoreDeForm()
In-reply-to: <326723ee-ee05-35bf-06fd-e4f3afc61654@dunslane.net>
References: <17994-5c7100b51b4790e9@postgresql.org>
 <1306569.1687978174@sss.pgh.pa.us>
 <20230628194446.uu47f4vyfyjfl7dd@awork3.anarazel.de>
 <1314841.1687981948@sss.pgh.pa.us>
 <20230628205443.6gu5bmcck6t4pgyv@awork3.anarazel.de>
 <e52f6028-7196-8545-9726-a17a50ea14a3@dunslane.net>
 <e6cbff03-32c3-4048-78b6-54d2907ba852@dunslane.net>
 <1509402.1688048784@sss.pgh.pa.us>
 <7ae37634-7626-8977-4d89-20603f0d1dcf@dunslane.net>
 <1583514.1688066735@sss.pgh.pa.us>
 <326723ee-ee05-35bf-06fd-e4f3afc61654@dunslane.net>
Comments: In-reply-to Andrew Dunstan <andrew@dunslane.net>
	message dated "Thu, 29 Jun 2023 16:30:21 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1610275.1688078516.1@sss.pgh.pa.us>
Date: Thu, 29 Jun 2023 18:41:56 -0400
Message-ID: <1610276.1688078516@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1610276.1688078516%40sss.pgh.pa.us>
Precedence: bulk

Andrew Dunstan <andrew@dunslane.net> writes:
> On 2023-06-29 Th 15:25, Tom Lane wrote:
>> Maybe we should bite the bullet and provide
>> invalidation based on a pg_type inval callback.

> Yeah, Robert has just convinced me, so I'll do it like that. It doesn't 
> look too hard.

Oh, I have a better idea.  We're only going to need all this for
pass-by-ref types, right?  Why not make the hash key be the value
itself?  Wrap it in a bytea perhaps to avoid needing a bespoke
hash function.

			regards, tom lane