From: Tom Lane <tgl@sss.pgh.pa.us>
To: zuming.jiang@inf.ethz.ch
cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18276: Heap-buffer-overflow triggered in
 src/backend/utils/adt/datum.c:163
In-reply-to: <18276-13b98d6ec97ed5b8@postgresql.org>
References: <18276-13b98d6ec97ed5b8@postgresql.org>
Comments: In-reply-to PG Bug reporting form <noreply@postgresql.org>
	message dated "Sun, 07 Jan 2024 17:50:34 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1633849.1704655019.1@sss.pgh.pa.us>
Date: Sun, 07 Jan 2024 14:16:59 -0500
Message-ID: <1633850.1704655019@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1633850.1704655019%40sss.pgh.pa.us>
Precedence: bulk

PG Bug reporting form <noreply@postgresql.org> writes:
> My fuzzer finds a heap-buffer-overflow bug in PostgreSQL 17devel, which
> makes PostgreSQL crash.

All I see here is a datatype declaration that doesn't match what the
C functions expect.  You wrote:

> CREATE TYPE widget (
>    input = widget_in,
>    output = widget_out,
>    alignment = double
> );

but the declaration that the regress.so functions expect is what's in
src/test/regress/sql/create_type.sql:

CREATE TYPE widget (
   internallength = 24,
   input = widget_in,
   output = widget_out,
   typmod_in = numerictypmodin,
   typmod_out = numerictypmodout,
   alignment = double
);

That is, widget_in expects it should produce a fixed-length Datum
(24 bytes long, with no length word).  But you declared the type
as variable-length, meaning that datumCopy expects to find a length
word.  That discrepancy leads directly to the reported crash.

			regards, tom lane