From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Heikki Linnakangas <hlinnaka@iki.fi>,
        =?UTF-8?Q?Bastien_Roucari=C3=A8s?= <rouca@debian.org>,
        pgsql-bugs@lists.postgresql.org
Subject: Re: Detection of hadware feature => please do not use signal
In-reply-to: <1624905.1730436275@sss.pgh.pa.us>
References: <4496616.iHFcN1HehY@portable-bastien>
 <af84e934-4e9c-4380-95ee-8921dab1254b@iki.fi>
 <1156374.1730396928@sss.pgh.pa.us>
 <7ec1c65c-1a28-49a7-af43-f77c260a3df6@iki.fi>
 <1292593.1730399134@sss.pgh.pa.us>
 <CA+hUKGLRXq0-s0n2=dy_A5iY-Omg628osyJEJMjPQ=6m566UgA@mail.gmail.com>
 <1624905.1730436275@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Fri, 01 Nov 2024 00:44:35 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1637253.1730441792.1@sss.pgh.pa.us>
Date: Fri, 01 Nov 2024 02:16:32 -0400
Message-ID: <1637254.1730441792@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1637254.1730441792%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> Hmm.  So it seems like we could do this:
> * Linux, FreeBSD, OpenBSD: do run-time test as recommended
> * Windows, macOS: assume that supported ARM hardware can do this
> * anything else: assume no hardware CRC

Actually, after chewing on that second point awhile longer,
how about this modest proposal:

* Drop all code for run-time determination of ARM CRC support.
Assume it's there unless user builds with a -march option that
says it definitely isn't.

Realistically, exactly who is going to be running Postgres 18+
on ARM hardware that lacks CRC support?  I can think of lots of
projects that are more worthy of our time than this.

(Perhaps it's time to apply the same mindset to x86 CRC support
too?)

			regards, tom lane