From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
cc: cyg0810@gmail.com,
        PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17067: FailedAssertion at castNodeImpl
In-reply-to: 
 <CAApHDvppyj_WrraCrSgQvDd_NGJp87S6ht6OzjytomMNqa_rxw@mail.gmail.com>
References: <17067-665d50fa321f79e0@postgresql.org>
 <CAApHDvppyj_WrraCrSgQvDd_NGJp87S6ht6OzjytomMNqa_rxw@mail.gmail.com>
Comments: In-reply-to David Rowley <dgrowleyml@gmail.com>
	message dated "Mon, 21 Jun 2021 21:47:49 +1200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1641483.1624282409.1@sss.pgh.pa.us>
Date: Mon, 21 Jun 2021 09:33:29 -0400
Message-ID: <1641484.1624282409@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1641484.1624282409%40sss.pgh.pa.us>
Precedence: bulk

David Rowley <dgrowleyml@gmail.com> writes:
> On Mon, 21 Jun 2021 at 20:15, PG Bug reporting form
> <noreply@postgresql.org> wrote:
>> run the following sql command through client and the PostgreSQL database
>> process will crash:

> Thanks for the report.  It looks like a thinko in 1d581ce71.   Code
> was added there which insists the initial list element is a List, but
> it's an IntList.  I think the code should just use linitial instead of
> linitial_node.

Hmm, if it's an int-list then the subsequent dup-elimination loop is
also wrong, and for that matter I don't think the preceding lines
would have worked.

> I'm quite surprised that we don't have a test that picks this up.

The code coverage report shows that we *do* have tests that run
through this code, so the existing typing is okay in the test cases
we have.  I'm guessing the real problem is that something upstream is
generating the wrong type of list in this example.

			regards, tom lane