pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
BUG #16468: Doc: release note 13, missing GUC enable_groupingsets_hash_disk
4+ messages / 3 participants
[nested] [flat]

Commits from this thread:
  2020-06-03 4d685f6d7b  doc:  PG 13 relnotes:  fix link for grouping sets hash overflow
* BUG #16468: Doc: release note 13, missing GUC enable_groupingsets_hash_disk
@ 2020-05-28 06:39 PG Bug reporting form <noreply@postgresql.org>
  2020-05-28 07:12 ` Re: BUG #16468: Doc: release note 13, missing GUC enable_groupingsets_hash_disk Michael Paquier <michael@paquier.xyz>
  0 siblings, 1 reply; 4+ messages in thread

From: PG Bug reporting form @ 2020-05-28 06:39 UTC (permalink / raw)
  To: pgsql-bugs@lists.postgresql.org; +Cc: harukat@sraoss.co.jp

The following bug has been logged on the website:

Bug reference:      16468
Logged by:          TAKATSUKA Haruka
Email address:      harukat@sraoss.co.jp
PostgreSQL version: 13beta1
Operating system:   Any
Description:        

> Allow grouping sets to use hash aggregation with disk storage for large
> grouping set results (Jeff Davis)
>
> Previously, hash aggregation was avoided if it was expected to use
> more than work_mem memory. This is controlled by enable_hashagg_disk.

It seems to me that the "enable_hashagg_disk" is mistaken for
"enable_groupingsets_hash_disk".



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: BUG #16468: Doc: release note 13, missing GUC enable_groupingsets_hash_disk
  2020-05-28 06:39 BUG #16468: Doc: release note 13, missing GUC enable_groupingsets_hash_disk PG Bug reporting form <noreply@postgresql.org>
@ 2020-05-28 07:12 ` Michael Paquier <michael@paquier.xyz>
  2020-06-03 02:12   ` Re: BUG #16468: Doc: release note 13, missing GUC enable_groupingsets_hash_disk Bruce Momjian <bruce@momjian.us>
  0 siblings, 1 reply; 4+ messages in thread

From: Michael Paquier @ 2020-05-28 07:12 UTC (permalink / raw)
  To: harukat@sraoss.co.jp; pgsql-bugs@lists.postgresql.org; +Cc: Bruce Momjian <bruce@momjian.us>

On Thu, May 28, 2020 at 06:39:34AM +0000, PG Bug reporting form wrote:
> It seems to me that the "enable_hashagg_disk" is mistaken for
> "enable_groupingsets_hash_disk".

Good catch.  This is not fixed yet on HEAD.  Adding Bruce in CC as
that's part of the release notes.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: BUG #16468: Doc: release note 13, missing GUC enable_groupingsets_hash_disk
  2020-05-28 06:39 BUG #16468: Doc: release note 13, missing GUC enable_groupingsets_hash_disk PG Bug reporting form <noreply@postgresql.org>
  2020-05-28 07:12 ` Re: BUG #16468: Doc: release note 13, missing GUC enable_groupingsets_hash_disk Michael Paquier <michael@paquier.xyz>
@ 2020-06-03 02:12   ` Bruce Momjian <bruce@momjian.us>
  2020-06-03 02:28     ` Re: BUG #16468: Doc: release note 13, missing GUC enable_groupingsets_hash_disk Michael Paquier <michael@paquier.xyz>
  0 siblings, 1 reply; 4+ messages in thread

From: Bruce Momjian @ 2020-06-03 02:12 UTC (permalink / raw)
  To: Michael Paquier <michael@paquier.xyz>; +Cc: harukat@sraoss.co.jp; pgsql-bugs@lists.postgresql.org

On Thu, May 28, 2020 at 04:12:53PM +0900, Michael Paquier wrote:
> On Thu, May 28, 2020 at 06:39:34AM +0000, PG Bug reporting form wrote:
> > It seems to me that the "enable_hashagg_disk" is mistaken for
> > "enable_groupingsets_hash_disk".
> 
> Good catch.  This is not fixed yet on HEAD.  Adding Bruce in CC as
> that's part of the release notes.

Thanks, attached patcy applied.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee

Attachments:

rel.diff (text/x-diff, 567B) download diff --git a/doc/src/sgml/release-13.sgml b/doc/src/sgml/release-13.sgml index 6543f8b910..6fb32ef57c 100644 --- a/doc/src/sgml/release-13.sgml +++ b/doc/src/sgml/release-13.sgml @@ -645,7 +645,7 @@ Author: Jeff Davis <jdavis@postgresql.org> <para> Previously, hash aggregation was avoided if it was expected to use more than <xref linkend="guc-work-mem"/> memory. This is controlled - by <xref linkend="guc-enable-hashagg-disk"/>. + by <xref linkend="guc-enable-groupingsets-hash-disk"/>. </para> </listitem>
^ permalink raw reply [nested|flat] 4+ messages in thread

* Re: BUG #16468: Doc: release note 13, missing GUC enable_groupingsets_hash_disk
  2020-05-28 06:39 BUG #16468: Doc: release note 13, missing GUC enable_groupingsets_hash_disk PG Bug reporting form <noreply@postgresql.org>
  2020-05-28 07:12 ` Re: BUG #16468: Doc: release note 13, missing GUC enable_groupingsets_hash_disk Michael Paquier <michael@paquier.xyz>
  2020-06-03 02:12   ` Re: BUG #16468: Doc: release note 13, missing GUC enable_groupingsets_hash_disk Bruce Momjian <bruce@momjian.us>
@ 2020-06-03 02:28     ` Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 4+ messages in thread

From: Michael Paquier @ 2020-06-03 02:28 UTC (permalink / raw)
  To: Bruce Momjian <bruce@momjian.us>; +Cc: harukat@sraoss.co.jp; pgsql-bugs@lists.postgresql.org

On Tue, Jun 02, 2020 at 10:12:04PM -0400, Bruce Momjian wrote:
> Thanks, attached patch applied.

Thanks!
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

^ permalink  raw  reply  [nested|flat] 4+ messages in thread


end of thread, other threads:[~2020-06-03 02:28 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-05-28 06:39 BUG #16468: Doc: release note 13, missing GUC enable_groupingsets_hash_disk PG Bug reporting form <noreply@postgresql.org>
2020-05-28 07:12 ` Michael Paquier <michael@paquier.xyz>
2020-06-03 02:12   ` Bruce Momjian <bruce@momjian.us>
2020-06-03 02:28     ` Michael Paquier <michael@paquier.xyz>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox