From: Tom Lane <tgl@sss.pgh.pa.us>
To: Zsolt Ero <zsolt.ero@gmail.com>
cc: Magnus Hagander <magnus@hagander.net>,
        PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>,
        Daniel Gustafsson <daniel@yesql.se>
Subject: Re: BUG #16604: pg_dump with --jobs breaks SSL connections
In-reply-to: <1663666.1600968283@sss.pgh.pa.us>
References: <16604-933f4b8791227b15@postgresql.org>
 <61B1FFD2-EA7B-4C62-92A1-44C5459189C0@yesql.se>
 <CABUevEwwr=oCNQnu2RUTLhKwyKxRh3C__ckum=Xgm+acgUEJ_Q@mail.gmail.com>
 <CAKw-smBKagNkWRZvTujeKgx6j5ZkjazDvDPFq9bZWbBC7YXqbg@mail.gmail.com>
 <1638874.1600963896@sss.pgh.pa.us> <1663666.1600968283@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Thu, 24 Sep 2020 13:24:43 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1664515.1600969345.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 24 Sep 2020 13:42:25 -0400
Message-ID: <1664516.1600969345@sss.pgh.pa.us>
Precedence: bulk

I wrote:
> Note, however, that AFAICS parallel pg_restore was okay on duplicating
> the original connection parameters otherwise (the prompting issue
> was because it went too far with that...).  So I fail to confirm
> the OP's claim that pg_restore had the same bug as parallel pg_dump.
> If there really is an issue there, we'll need a test case that
> demonstrates it.

Hmm ... so a bit later, I have a test case that may or may not be
what Zsolt saw:

pg_restore -C --dbname=3D"hostaddr=3D127.0.0.1 sslmode=3Dverify-ca dbname=3D=
postgres user=3Dpostgres sslcert=3Dclient-cert.crt sslkey=3Dclient-cert.ke=
y" -Fd  dumpdir
pg_restore: error: could not reconnect to database: FATAL:  connection req=
uires a valid client certificate

What is happening here is the exact same issue, but in
ReconnectToServer/_connectDB: those functions suppose that they
can blow away all the original connection parameters and insert
just a database name instead.  I'm inclined to think that
we should get rid of _connectDB, because it seems unnecessarily
duplicative with ConnectDatabase.  But we'll need a bit more
API refactoring than what I had.  New patch coming ...

			regards, tom lane