From: Tom Lane <tgl@sss.pgh.pa.us>
To: ml+postgresql@03s.net
cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17083: [PATCH] PostgreSQL fails to build with OpenLDAP 2.5.x
In-reply-to: <17083-a19190d9591946a7@postgresql.org>
References: <17083-a19190d9591946a7@postgresql.org>
Comments: In-reply-to PG Bug reporting form <noreply@postgresql.org>
	message dated "Tue, 06 Jul 2021 11:42:34 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1666181.1625579201.1@sss.pgh.pa.us>
Date: Tue, 06 Jul 2021 09:46:41 -0400
Message-ID: <1666182.1625579201@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1666182.1625579201%40sss.pgh.pa.us>
Precedence: bulk

PG Bug reporting form <noreply@postgresql.org> writes:
> OpenLDAP 2.5 merged the `ldap_r` and `ldap` libraries, so all per-handle
> routines are now thread-safe by default.

Hm, does 2.5 exist in the wild yet?  I checked Fedora rawhide, which
is my usual go-to platform for bleeding-edge stuff, but they are still
at 2.4.58.

As for the patch itself, I'm wondering about

+      LDAP_LIBS_FE="${ac_lib:+-l}$ac_lib $EXTRA_LDAP_LIBS"

That seems undesirably intimate with the implementation details
of AC_SEARCH_LIBS.  Surely there's a better way?

			regards, tom lane