From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Thomas Munro <thomas.munro@gmail.com>, cees.van.zeeland@freedom.nl,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18362: unaccent rules and Old Greek text
In-reply-to: <ZdvMcEkMYoMqELiG@paquier.xyz>
References: <18362-be6d0cfe122b6354@postgresql.org>
 <CA+hUKGLpoxTRryM1MxaHMpC1c5cxoKDm0iXfogQR9KGVUG=w9w@mail.gmail.com>
 <CA+hUKG+nL9VYx5S_mPnraXKLKcWP_WFkTrwKb1osq0q=am6fEw@mail.gmail.com>
 <ZdvMcEkMYoMqELiG@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Mon, 26 Feb 2024 08:25:36 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <1667234.1708905577.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Sun, 25 Feb 2024 18:59:37 -0500
Message-ID: <1667235.1708905577@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1667235.1708905577%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Feb 26, 2024 at 12:15:57PM +1300, Thomas Munro wrote:
>> That has a normal looking sequence that we can understand (α + an
>> accent).  If I tell the script to follow such "simple" redirections, I
>> get over a thousand new mappings, including those.  See attached.
>> There is probably more correct terminology that I'm using here...

> Ah, you've beaten me to it.  Yes, that's pretty much the impression I
> was getting while looking at the set of characters in Unicode.txt.  I
> am not entirely sure if what you are doing is the best way to do it,
> but the set of characters generated in unaccent.rules makes sense
> here.  I am surprised to see that many, TBH.

There are only about 1650 lines in our standard unaccent.rules
file today.  Are we concerned about adding so many more?
I don't think the trie lookup logic would be slowed any,
but the time to load the rules file might take a hit.

			regards, tom lane