From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Jeff Janes <jeff.janes@gmail.com>, Matthias Otterbach <mo@otterbach.eu>,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15700: PG 10 vs. 11: Large increase in memory usage when
 selecting BYTEA data (maybe memory leak)
In-reply-to: <13467.1552942521@sss.pgh.pa.us>
References: <15700-8c408321a87d56bb@postgresql.org>
 <16717.1552926811@sss.pgh.pa.us>
 <4ef5f38d5710c4d5c289537c588c7335@otterbach.eu>
 <CAMkU=1wW32K8n4ut_7zz+6HH1J068tFtpv5os=eeAgvjiQH8ZQ@mail.gmail.com>
 <CAMkU=1x_XySqXZ-1gCyoaipKLzefQSr1BuaHL12vy_9WKFnjYQ@mail.gmail.com>
 <13467.1552942521@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Mon, 18 Mar 2019 16:55:21 -0400"
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----- =_aaaaaaaaaa0"
Content-ID: <16682.1552945040.0@sss.pgh.pa.us>
Date: Mon, 18 Mar 2019 17:37:41 -0400
Message-ID: <16692.1552945061@sss.pgh.pa.us>
Precedence: bulk

------- =_aaaaaaaaaa0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <16682.1552945040.1@sss.pgh.pa.us>

I wrote:
> Jeff Janes <jeff.janes@gmail.com> writes:
>> The culprit is f2dec34e19d3969ddd6.

> Hmm.  I bet problem is that the buf isn't being freed in
> printtup_shutdown.

Yup; the attached fixes it.  Will push after a bit more testing.

			regards, tom lane


------- =_aaaaaaaaaa0
Content-Type: text/x-diff; name="fix-printtup-leak.patch";
	charset="us-ascii"
Content-ID: <16682.1552945040.2@sss.pgh.pa.us>
Content-Description: fix-printtup-leak.patch
Content-Transfer-Encoding: quoted-printable

diff --git a/src/backend/access/common/printtup.c b/src/backend/access/com=
mon/printtup.c
index e4ee5c9..5eb928b 100644
*** a/src/backend/access/common/printtup.c
--- b/src/backend/access/common/printtup.c
*************** printtup_create_DR(CommandDest dest)
*** 91,96 ****
--- 91,97 ----
  	 */
  	self->sendDescrip =3D (dest =3D=3D DestRemote);
  =

+ 	self->buf.data =3D NULL;
  	self->attrinfo =3D NULL;
  	self->nattrs =3D 0;
  	self->myinfo =3D NULL;
*************** printtup_shutdown(DestReceiver *self)
*** 547,552 ****
--- 548,557 ----
  	if (myState->tmpcontext)
  		MemoryContextDelete(myState->tmpcontext);
  	myState->tmpcontext =3D NULL;
+ =

+ 	if (myState->buf.data)
+ 		pfree(myState->buf.data);
+ 	myState->buf.data =3D NULL;
  }
  =

  /* ----------------

------- =_aaaaaaaaaa0--