pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
BUG #16697: timetz regression test seems to have a false failure
2+ messages / 2 participants
[nested] [flat]

* BUG #16697: timetz regression test seems to have a false failure
@ 2020-11-03 01:55  PG Bug reporting form <noreply@postgresql.org>
  0 siblings, 1 reply; 2+ messages in thread

From: PG Bug reporting form @ 2020-11-03 01:55 UTC (permalink / raw)
  To: pgsql-bugs@lists.postgresql.org; +Cc: russkubes@yahoo.com

The following bug has been logged on the website:

Bug reference:      16697
Logged by:          Russel Kubes
Email address:      russkubes@yahoo.com
PostgreSQL version: 12.4
Operating system:   Linux debian-vm 4.19.0-12-amd64 #1 SMP Debian 4.19
Description:        

While building Postgres 12.4 from source today on two different machines,
the "timetz" test has failed. When reviewing the "diff" file, it looks like
the only reason they failed is a differing UTC offset after a query that
looks like the UTC offset isn't really relevant. I've built 12.4 a few times
before on each machine and did not run into this issue. It started today,
which makes me wonder if it has something to do with Daylight Saving Time.

I feel confident that I can ignore this error. However, I wanted to pass it
along just in case someone can determine whether this is a minor issue in
the regression test, or if there's a potential edge case issue in the actual
Postgresql code.

The output of the "regression.diffs" file is pasted below:

diff -U3
./postgres/obj/../postgresql-12.4/src/test/regress/expected/timetz.out
./postgres/obj/src/test/regress/results/timetz.out
---
./postgres/obj/../postgresql-12.4/src/test/regress/expected/timetz.out	2020-08-10
17:15:53.000000000 -0400
+++ ./postgres/obj/src/test/regress/results/timetz.out	2020-11-02
20:35:14.681128516 -0500
@@ -94,25 +94,25 @@
 SELECT '23:59:59.999999'::timetz;
        timetz       
 --------------------
- 23:59:59.999999-07
+ 23:59:59.999999-08
 (1 row)
 
 SELECT '23:59:59.9999999'::timetz;  -- rounds up
    timetz    
 -------------
- 24:00:00-07
+ 24:00:00-08
 (1 row)
 
 SELECT '23:59:60'::timetz;  -- rounds up
    timetz    
 -------------
- 24:00:00-07
+ 24:00:00-08
 (1 row)
 
 SELECT '24:00:00'::timetz;  -- allowed
    timetz    
 -------------
- 24:00:00-07
+ 24:00:00-08
 (1 row)
 
 SELECT '24:00:00.01'::timetz;  -- not allowed



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: BUG #16697: timetz regression test seems to have a false failure
@ 2020-11-03 10:40  Michael Paquier <michael@paquier.xyz>
  parent: PG Bug reporting form <noreply@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Michael Paquier @ 2020-11-03 10:40 UTC (permalink / raw)
  To: russkubes@yahoo.com; pgsql-bugs@lists.postgresql.org

On Tue, Nov 03, 2020 at 01:55:54AM +0000, PG Bug reporting form wrote:
> I feel confident that I can ignore this error. However, I wanted to pass it
> along just in case someone can determine whether this is a minor issue in
> the regression test, or if there's a potential edge case issue in the actual
> Postgresql code.
> 
> The output of the "regression.diffs" file is pasted below:

These have been failing because of the Winter/Summer time difference,
and 4a071afb has already fixed this stuff.

Here is the thread of the commit:
https://www.postgresql.org/message-id/16689-57701daa23b377bf@postgresql.org

So things will be fixed with the next minor release.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2020-11-03 10:40 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-11-03 01:55 BUG #16697: timetz regression test seems to have a false failure PG Bug reporting form <noreply@postgresql.org>
2020-11-03 10:40 ` Michael Paquier <michael@paquier.xyz>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox