From: Tom Lane <tgl@sss.pgh.pa.us>
To: Hugh Ranalli <hugh@whtc.ca>
cc: Daniel Verite <daniel@manitou-mail.org>, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15548: Unaccent does not remove combining diacritical
 characters
In-reply-to: 
 <CAAhbUMNqJXTN+_vYdi5L4CLjoq9OCG29V597RKrCQ7xKsCAejA@mail.gmail.com>
References: <10200.1544713542@sss.pgh.pa.us>
 <5d77cc08-d582-4f83-a17f-f2c992d123a9@manitou-mail.org>
 <CAAhbUMOHkoN3Jeti4dp1jz3VY=XZPcCqpX=sW=mgmJbdMS--ng@mail.gmail.com>
 <CAAhbUMNqJXTN+_vYdi5L4CLjoq9OCG29V597RKrCQ7xKsCAejA@mail.gmail.com>
Comments: In-reply-to Hugh Ranalli <hugh@whtc.ca>
	message dated "Fri, 14 Dec 2018 17:42:05 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <16725.1544827803.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Fri, 14 Dec 2018 17:50:03 -0500
Message-ID: <16726.1544827803@sss.pgh.pa.us>
Precedence: bulk

Hugh Ranalli <hugh@whtc.ca> writes:
> I've attached a patch removes combining diacriticals. As with Latin and
> Greek letters, it uses ranges to restrict its activity.

Cool.  Please add it to the current CF so we don't forget about it:
https://commitfest.postgresql.org/21/

> I have not submitted a patch for unaccent.rules, as it seems that a rules
> file generated from generate_unaccent_rules.py will actually remove a large
> number of rules (even before my changes), such as replacing the copyright
> symbol © with (C), as well as other accented characters. It's probably
> worth asking if the shipped unaccent.rules should correspond to what the
> shipped generation utility produces, or not. I was surprised to see that it
> didn't.

Me too -- seems like that bears looking into.  Perhaps the script's
results are platform dependent -- what were you testing on?

			regards, tom lane