From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: Mats Kindahl <mats@timescale.com>, daniel@yesql.se,
        pgsql-bugs@lists.postgresql.org
Subject: Re: Crash during backend start when low on memory
In-reply-to: <20230113115352.sbuv5egpjyoxn52i@alvherre.pgsql>
References: <20230113115352.sbuv5egpjyoxn52i@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@alvh.no-ip.org>
	message dated "Fri, 13 Jan 2023 12:53:52 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1676514.1673622084.1@sss.pgh.pa.us>
Date: Fri, 13 Jan 2023 10:01:24 -0500
Message-ID: <1676515.1673622084@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1676515.1673622084%40sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2023-Jan-13, Mats Kindahl wrote:
>> I have an improved patch based on raising an error when malloc fails.

> Hmm, but I'm not sure I like what you did to BackendStartup:

Yeah, the BackendStartup change is 100% wrong; it is replacing
perfectly good code that recovers correctly with bad code that
will take down the postmaster (not a backend child!) on OOM.

By and large I don't like anything about this patch.  You could
get the same results (i.e. elog(ERROR) on OOM) by replacing the
malloc calls with pallocs.

			regards, tom lane