From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Euler Taveira" <euler@eulerto.com>
cc: webbohan@qq.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19073: there are meaningless code in _SPI_execute_plan()
 when canSetTag is true
In-reply-to: <5b04da16-c2de-464b-8677-9e4991b28e55@app.fastmail.com>
References: <19073-93772b97a2f1ecf3@postgresql.org>
 <5b04da16-c2de-464b-8677-9e4991b28e55@app.fastmail.com>
Comments: In-reply-to "Euler Taveira" <euler@eulerto.com>
	message dated "Sun, 05 Oct 2025 11:47:59 -0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1680815.1759679313.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sun, 05 Oct 2025 11:48:33 -0400
Message-ID: <1680816.1759679313@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1680816.1759679313%40sss.pgh.pa.us>
Precedence: bulk

"Euler Taveira" <euler@eulerto.com> writes:
> On Sat, Oct 4, 2025, at 11:29 PM, PG Bug reporting form wrote:
>> If plan is canSetTag subqueries, `SPI_freetuptable(my_tuptable)` is
>> meaningless, because `my_tuptable` is NULL.

> There could be multiple statements. The first case will call SPI_freetup=
table()
> and it is a noop. The code path you are referring to is inside a foreach=
 loop
> and a previous statement might set my_tuptable and needs to be freed bef=
ore
> reusing it. That's exactly what the comment says.

Yeah.  You'd only reach this case if there were multiple SQL
statements in the string given to SPI_execute() or similar,
but that's perfectly legal.

			regards, tom lane