From: Bastien =?ISO-8859-1?Q?Roucari=E8s?= <rouca@debian.org>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Heikki Linnakangas <hlinnaka@iki.fi>,
 pgsql-bugs@lists.postgresql.org
Subject: Re: Detection of hadware feature => please do not use signal
Date: Fri, 08 Nov 2024 08:56:45 +0000
Message-ID: <16872859.Zp9ysIU8Tl@portable-bastien>
In-Reply-To: 
 <CA+hUKGKrfMUuhQNqT5WhQYfu5JhtKkfW62WbELTnLi8xbk9=Kg@mail.gmail.com>
References: 
 <4496616.iHFcN1HehY@portable-bastien> <4188473.jn8P2z2zlG@portable-bastien>
 <CA+hUKGKrfMUuhQNqT5WhQYfu5JhtKkfW62WbELTnLi8xbk9=Kg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart12721882.LBLKqaJk8l";
 micalg="pgp-sha512"; protocol="application/pgp-signature"
Archived-At: 
 <https://www.postgresql.org/message-id/16872859.Zp9ysIU8Tl%40portable-bastien>
Precedence: bulk

--nextPart12721882.LBLKqaJk8l
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"; protected-headers="v1"
From: Bastien =?ISO-8859-1?Q?Roucari=E8s?= <rouca@debian.org>
To: Thomas Munro <thomas.munro@gmail.com>
Subject: Re: Detection of hadware feature => please do not use signal
Date: Fri, 08 Nov 2024 08:56:29 +0000
Message-ID: <16872859.Zp9ysIU8Tl@portable-bastien>
MIME-Version: 1.0

Le jeudi 7 novembre 2024, 23:43:45 UTC Thomas Munro a =C3=A9crit :
> On Fri, Nov 8, 2024 at 4:51=E2=80=AFAM Bastien Roucari=C3=A8s <rouca@debi=
an.org> wrote:
> > Le jeudi 7 novembre 2024, 00:01:58 UTC Thomas Munro a =C3=A9crit :
> > > It doesn't look like I need to include <asm/hwcap.h> from Bastien's
> > > original message, because <sys/auxv.h> pulls in <bits/hwcap.h>
>=20
> > Not on arm32 unfortunatly.... and it is a HWCAP2_flags
>=20
> Ah, that is unfortunate.  I was confused about whether we even used
> this code on armv7/aarch32 builds, but I see that we do.  OK, here is
> a version like that.

I will guard the include by replacing
+#if defined(__linux__) && !defined(__aarch64__)
by
+#if defined(__linux__) && !defined(__aarch64__) && !defined(HWCAP2_CRC32)

>=20
> I also noticed that the Linux docs explicitly tell you that SIGILL is
> unreliable for this purpose:
>=20
> https://docs.kernel.org/arch/arm64/elf_hwcaps.html
>=20
Bastien

--nextPart12721882.LBLKqaJk8l
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEXQGHuUCiRbrXsPVqADoaLapBCF8FAmct0j0ACgkQADoaLapB
CF8CNA//fG6o9TUsh38TY+wfIDjRBCcY2CCIHhnumjTyuPR+TV11JswH18aPmusI
T3qHVonxjeUfrTYUnmYt9hE4DF52EJuwsd3dIL+o6regg/TylZVy8lYx3fA9Cprt
3z5InJHkWM8hU8/KrfE/BVe5Pdcpoc3YjeVNKYmg6mo44P0/YotX9D4+jMapdQWE
rEUgduaIys8jFFzsbW4V9QIth2FEDz8Uwdbep2PVxuV957H09EQZpju19XxsRaP1
oRxJKqzVgeDAHlNYUDvaMa1vMY8YhVj1yLgbCRDLhRzzB/JH4CAmQjwdQVSU8PSe
RdrNeXVwEAxwxO/FdF5w+CrpCImWcW4/5k7/vv1yrxoiQhAq9ON0bQpiA/N8pZTW
RnX9E4VS7cMbZvsjggiC+8781YN83b4HQU2JBlYe72w/gD4W+9zE68MFuiNjcwPC
aEfpBtMgzwav95v79Azjkd3r2yBQqxzJ8kZxBFcnz/oxsMEy85XyXF8imGQERAfl
eclQ4u4Fqxi/BuggivYtDw3zVQZkYltUC+D49qYAHDrwf3RdIn6JT3BiT9gF0akv
fiD5905kq7rxqc9cgpLIVhExLISpedYGC+Y0P8sVi3HmjP7OqYtbRw/WaLNxZr9g
LLyzseYzZ0cwD7xQxjxR9+veN0+NhGVkxEXA36ZoGIG+e5CpZj8=
=CDBc
-----END PGP SIGNATURE-----

--nextPart12721882.LBLKqaJk8l--