pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
BUG #16896: pg_standby: Missing reference when building on Windows
3+ messages / 3 participants
[nested] [flat]

* BUG #16896: pg_standby: Missing reference when building on Windows
@ 2021-02-24 21:38  PG Bug reporting form <noreply@postgresql.org>
  0 siblings, 1 reply; 3+ messages in thread

From: PG Bug reporting form @ 2021-02-24 21:38 UTC (permalink / raw)
  To: pgsql-bugs@lists.postgresql.org; +Cc: robionekenobi@bluewin.ch

The following bug has been logged on the website:

Bug reference:      16896
Logged by:          RobiOne (Robert Grange)
Email address:      robionekenobi@bluewin.ch
PostgreSQL version: 13.2
Operating system:   Windows 10
Description:        

Hi,

after building on windows (cleant.bat then build.bat Debug', the pg_standby
project is missing references to libpgport and libpgcommon

The error is probalby in src/tools/msvc/Mkvcbuild.pm, as the lines

my @contrib_uselibpgport   = ('oid2name', 'vacuumlo');
my @contrib_uselibpgcommon = ('oid2name', 'vacuumlo');

must be

my @contrib_uselibpgport   = ('oid2name', 'pg_standby', 'vacuumlo');
my @contrib_uselibpgcommon = ('oid2name', 'pg_standby', 'vacuumlo');

After having added this locally, all worked fine
Robert



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: BUG #16896: pg_standby: Missing reference when building on Windows
@ 2021-02-25 08:23  Magnus Hagander <magnus@hagander.net>
  parent: PG Bug reporting form <noreply@postgresql.org>
  0 siblings, 1 reply; 3+ messages in thread

From: Magnus Hagander @ 2021-02-25 08:23 UTC (permalink / raw)
  To: robionekenobi@bluewin.ch, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>

On Thu, Feb 25, 2021 at 9:17 AM PG Bug reporting form
<noreply@postgresql.org> wrote:
>
> The following bug has been logged on the website:
>
> Bug reference:      16896
> Logged by:          RobiOne (Robert Grange)
> Email address:      robionekenobi@bluewin.ch
> PostgreSQL version: 13.2
> Operating system:   Windows 10
> Description:
>
> Hi,
>
> after building on windows (cleant.bat then build.bat Debug', the pg_standby
> project is missing references to libpgport and libpgcommon
>
> The error is probalby in src/tools/msvc/Mkvcbuild.pm, as the lines
>
> my @contrib_uselibpgport   = ('oid2name', 'vacuumlo');
> my @contrib_uselibpgcommon = ('oid2name', 'vacuumlo');
>
> must be
>
> my @contrib_uselibpgport   = ('oid2name', 'pg_standby', 'vacuumlo');
> my @contrib_uselibpgcommon = ('oid2name', 'pg_standby', 'vacuumlo');
>
> After having added this locally, all worked fine


This sounds like you may have an unclean checkout with a mix of
version 13 and HEAD in it.

In version 13, pg_standby is already in those lines, and has been for
years. It has, however, been removed in HEAD back in January, along
with all of pg_standby. So if building HEAD then adding those back
should be failing. It looks like you have the src/tools/msvc directory
from HEAD and src/contrib from 13.

So you'll want to investigate why and make sure you have a completely
clean checkout.

-- 
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/





^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: BUG #16896: pg_standby: Missing reference when building on Windows
@ 2021-02-26 02:22  Michael Paquier <michael@paquier.xyz>
  parent: Magnus Hagander <magnus@hagander.net>
  0 siblings, 0 replies; 3+ messages in thread

From: Michael Paquier @ 2021-02-26 02:22 UTC (permalink / raw)
  To: Magnus Hagander <magnus@hagander.net>; +Cc: robionekenobi@bluewin.ch, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>

On Thu, Feb 25, 2021 at 09:23:28AM +0100, Magnus Hagander wrote:
> This sounds like you may have an unclean checkout with a mix of
> version 13 and HEAD in it.
> 
> In version 13, pg_standby is already in those lines, and has been for
> years. It has, however, been removed in HEAD back in January, along
> with all of pg_standby. So if building HEAD then adding those back
> should be failing. It looks like you have the src/tools/msvc directory
> from HEAD and src/contrib from 13.
>
> So you'll want to investigate why and make sure you have a completely
> clean checkout.

Agreed.  It looks so.

Out of curiosity, I have just checked on a clean tree that a build of
only pg_standby and of the whole thing.  Both work correctly with the
MSVC scripts.  And there are buildfarm machines running that on a
daily basis:
https://buildfarm.postgresql.org/cgi-bin/show_status.pl

But perhaps we are missing something in clean.bat?
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2021-02-26 02:22 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-02-24 21:38 BUG #16896: pg_standby: Missing reference when building on Windows PG Bug reporting form <noreply@postgresql.org>
2021-02-25 08:23 ` Magnus Hagander <magnus@hagander.net>
2021-02-26 02:22   ` Michael Paquier <michael@paquier.xyz>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox