From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Amit Kapila <amit.kapila16@gmail.com>, Noah Misch <noah@leadboat.com>,
        "Adam,
    Etienne (Nokia-TECH/Issy Les Moulineaux)" <etienne.adam@nokia.com>,
        PostgreSQL Bugs <pgsql-bugs@postgresql.org>,
        "Duquesne,
    Pierre (Nokia-TECH/Issy Les Moulineaux)" <pierre.duquesne@nokia.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] [postgresql 10 beta3] unrecognized node type: 90
In-reply-to: 
 <CA+TgmoabrmBs6WaJtnrkdyAnmcGUcNbsxm=H43Vs9Xj54BCWUA@mail.gmail.com>
References: 
 <CAL7LBcYM-32B=n_-h_wPHWiML26UvqP3b_WxD7MgXgOwmxvTFw@mail.gmail.com>
 <11673.1502467154@sss.pgh.pa.us> <20170815025243.GA3986579@rfd.leadboat.com>
 <CAA4eK1KeQWZOoDmDmGMwuqzPW9JhRS+ditQVFdAfGjNmMZzqMQ@mail.gmail.com>
 <CA+TgmoaWPtfdcZjg+dqLephgKaG7kF8DEdvB870A2t4cUh5x+Q@mail.gmail.com>
 <26053.1502804769@sss.pgh.pa.us>
 <CAA4eK1J_dRv+pGt2bquwmwd_K9+Nght2=tbAc3uUzCinJTMmLg@mail.gmail.com>
 <2941.1502979564@sss.pgh.pa.us>
 <CAA4eK1KeGhogrkO1JWo=WnvEHm_i9tz6-Gt65zELB1hi=P28Hw@mail.gmail.com>
 <CAA4eK1+qD0yfh-iNDKrM7=qMxPOd2KkCZRTX+uxYsDMn0RBwUQ@mail.gmail.com>
 <28782.1502992247@sss.pgh.pa.us> <29467.1502993219@sss.pgh.pa.us>
 <CA+Tgmob+S=c=wqaJXNgKT2VhhAVRYFz=MagoTDWb0MueM1xBxg@mail.gmail.com>
 <18650.1502995942@sss.pgh.pa.us> <1105.1503008416@sss.pgh.pa.us>
 <24667.1503865781@sss.pgh.pa.us>
 <CAA4eK1LqHdSL0nH04EJ79AnUeKCHPf-rpgkrYszYpKETVFM-Wg@mail.gmail.com>
 <3924.1503923486@sss.pgh.pa.us>
 <CAA4eK1+eEZ5+4jMdWtGtAGK9kDHDcH7Q_xNSxXZV_0wwhTPbZQ@mail.gmail.com>
 <CAA4eK1LcxZB0a-1_!
 2-GZsZhrX21uipznfjH0zs=iAsx7kk+oNw@mail.gmail.com>
 <13540.1503931678@sss.pgh.pa.us>
 <CA+TgmoabrmBs6WaJtnrkdyAnmcGUcNbsxm=H43Vs9Xj54BCWUA@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Mon, 28 Aug 2017 13:43:22 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <16977.1503946802.1@sss.pgh.pa.us>
Date: Mon, 28 Aug 2017 15:00:02 -0400
Message-ID: <16978.1503946802@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-bugs-owner@postgresql.org

Robert Haas <robertmhaas@gmail.com> writes:
> On Mon, Aug 28, 2017 at 10:47 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> - fuller description.  Academic literature on parallel query suggests that
> + fuller description.  The academic literature on parallel query suggests

> That sentence isn't wrong as written.

Count the "that"s (you're failing to notice the next line).

> I don't really understand the part about depending on a parallel-aware
> node.  I mean, there should always be one, except in the
> single-copy-Gather case, but why is it right to depend on that rather
> than anything else?  What happens when the Parallel Hash patch goes in
> and we have multiple parallel-aware scan nodes (plus a parallel-aware
> Hash node) under the same Gather?

Well, that's what I'm asking.  AFAICS we only really need the scan node(s)
to be marked as depending on the Gather's rescan parameter.  It would not,
however, hurt anything for nodes above them to be so marked as well ---
and even if we didn't explicitly mark them, those nodes would end up
depending on the parameter anyway because of the way that parameter
dependency propagation works.  I think the question boils down to whether
a "parallel_aware" node would ever not be underneath a related Gather.

			regards, tom lane


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs