From: Tom Lane <tgl@sss.pgh.pa.us>
To: Akshat Jaimini <destrex271@gmail.com>
cc: pgsql-hackers@lists.postgresql.org,
        Mikhail Zhilin <m.zhilin@postgrespro.ru>
Subject: Re: BUG: deadlock between autovacuum worker and client backend during
 removal of orphan temp tables with sequences
In-reply-to: 
 <171170826140.2046436.12738244831107414180.pgcf@coridan.postgresql.org>
References: <c43ce028-2bc2-4865-9b89-3f706246eed5@postgrespro.ru>
 <2B25F88E-E6AA-4883-B21B-936F7B5D5F78@yandex-team.ru>
 <171170826140.2046436.12738244831107414180.pgcf@coridan.postgresql.org>
Comments: In-reply-to Akshat Jaimini <destrex271@gmail.com>
	message dated "Fri, 29 Mar 2024 10:31:01 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1731081.1712084694.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 02 Apr 2024 15:04:54 -0400
Message-ID: <1731082.1712084694@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1731082.1712084694%40sss.pgh.pa.us>
Precedence: bulk

Akshat Jaimini <destrex271@gmail.com> writes:
> The code seems to implement the feature and has good and explanatory com=
ments associated with it.
> I believe we can go ahead with committing patch although I would request=
 some senior contributors to also take a look at this patch since I am rel=
atively new to patch reviews.

Looks like a good catch and a reasonable fix.  Pushed after rewriting
the comments a bit.

As far as this goes:

> I ran make installcheck-world after applying the patch and recompiling i=
t. It did fail for a particular test but from the logs it seems to be unre=
lated to this particular patch since it fails for the following:

> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D
> select error_trap_test();
> -      error_trap_test      =

> ----------------------------
> - division_by_zero detected
> -(1 row)
> -
> +ERROR:  cannot start subtransactions during a parallel operation

... that's the test case from 0075d7894, and the failure is what
I'd expect from a backend older than that.  Maybe you forgot to
recompile/reinstall after updating past that commit?

			regards, tom lane