From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        steven.winfield@cantabcapital.com
Subject: Re: BUG #16059: Tab-completion of filenames in COPY commands removes
 required quotes
In-reply-to: 
 <CA+TgmoYCAU6ZLJKpikCy82H7PrZYPP7pL_US0Sn18KtoQF0OwQ@mail.gmail.com>
References: <20191211150637.GA21159@alvherre.pgsql>
 <15389.1576079550@sss.pgh.pa.us>
 <CA+TgmoYCAU6ZLJKpikCy82H7PrZYPP7pL_US0Sn18KtoQF0OwQ@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Wed, 11 Dec 2019 10:57:30 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <17378.1576082091.1@sss.pgh.pa.us>
Date: Wed, 11 Dec 2019 11:34:51 -0500
Message-ID: <17379.1576082091@sss.pgh.pa.us>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Dec 11, 2019 at 10:52 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I think it's Debian's problem, not ours, if that doesn't work.  It is
>> not unreasonable for a package to probe existence of a library function
>> at configure time.  It's up to them to make sure that the headers match
>> the actual library.

> That seems like an unhelpful attitude. Debian is a mainstream
> platform, and no doubt feels that they have important reasons for what
> they are doing.

Nonetheless, if they're doing that, it's *their* bug not ours when
the run-time library fails to match what was supplied to compile
against.  I think it would fall to them to patch either libedit
or readline to make those two agree.  This is not different in any
way from the expectation that a platform supply a libc whose ABI
is stable.

In any case, this discussion is a bit hypothetical isn't it?
If I understand correctly, your concern is that the proposed
patch might fail to take advantage of functionality that actually
might be present at runtime.  So what?  It's no worse than before.
More, it's likely that there are other similar losses of functionality
already in our code and/or other peoples'.  Debian bought into that
tradeoff, not us.

			regards, tom lane