From: Tom Lane <tgl@sss.pgh.pa.us>
To: Richard Guo <guofenglinux@gmail.com>
cc: =?UTF-8?B?0JXQs9C+0YAg0KfQuNC90LTRj9GB0LrQuNC9?= <kyzevan23@mail.ru>,
        Alvaro Herrera <alvherre@alvh.no-ip.org>,
        PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: Re[2]: BUG #17561: Server crashes on executing row() with very
 long argument list
In-reply-to: 
 <CAMbWs4_hj8PFeRWkzndqf=VYj1E3dAKivVxQpdBU6n4DfpgTNw@mail.gmail.com>
References: <20220729101411.7b45rvhlrsgcajjo@alvherre.pgsql>
 <CAMbWs487ax-wLBEQ2be3MJYUUxZYPfmhxHF1gsOb7PQB1tTg=A@mail.gmail.com>
 <3822706.1659113869@sss.pgh.pa.us> <1659338229.499665470@f479.i.mail.ru>
 <CAMbWs48GiU-qucoJwH-p0pUY0OnrxZPXQjv7+HGzEPv6D18Vpg@mail.gmail.com>
 <CAMbWs4_1+f7j-HuU1yA298-eeY8GLDqOEmjhiwW-rx6WoNyTYA@mail.gmail.com>
 <CAMbWs4_hj8PFeRWkzndqf=VYj1E3dAKivVxQpdBU6n4DfpgTNw@mail.gmail.com>
Comments: In-reply-to Richard Guo <guofenglinux@gmail.com>
	message dated "Mon, 01 Aug 2022 18:51:26 +0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1745215.1659365738.1@sss.pgh.pa.us>
Date: Mon, 01 Aug 2022 10:55:38 -0400
Message-ID: <1745216.1659365738@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1745216.1659365738%40sss.pgh.pa.us>
Precedence: bulk

Richard Guo <guofenglinux@gmail.com> writes:
> Just noticed that CheckAttributeNamesTypes will check on column count
> against MaxHeapAttributeNumber. Maybe we should use this as the limit?

Yeah, otherwise you'll get a very confusing message about too many
columns in a *table*.

Also, there are two levels we have to check at, per-function and
then the merged tupdesc for the whole RTE.

I should have thought of function RTEs when asserting that there
were no other holes to plug :-(.  Will fix, thanks for the report!

			regards, tom lane