Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mGkfi-0007SA-DR for pgsql-bugs@arkaria.postgresql.org; Thu, 19 Aug 2021 16:13:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mGkfh-0006Jl-Aj for pgsql-bugs@arkaria.postgresql.org; Thu, 19 Aug 2021 16:13:37 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mGkfh-0006Jc-49 for pgsql-bugs@lists.postgresql.org; Thu, 19 Aug 2021 16:13:37 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mGkff-0003my-5f for pgsql-bugs@lists.postgresql.org; Thu, 19 Aug 2021 16:13:36 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 17JGDVpl1760362; Thu, 19 Aug 2021 12:13:31 -0400 From: Tom Lane To: Masahiko Sawada cc: 253540651@qq.com, PostgreSQL mailing lists Subject: Re: BUG #17151: A SEGV in optimizer In-reply-to: References: <17151-c03a3e6e4ec9aadb@postgresql.org> <1458262.1629302158@sss.pgh.pa.us> <1663590.1629329060@sss.pgh.pa.us> Comments: In-reply-to Masahiko Sawada message dated "Thu, 19 Aug 2021 10:02:44 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1760360.1629389611.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Thu, 19 Aug 2021 12:13:31 -0400 Message-ID: <1760361.1629389611@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Masahiko Sawada writes: > On Thu, Aug 19, 2021 at 8:24 AM Tom Lane wrote: >> We probably need some regression test cases added (I wonder whether >> FOR UPDATE in rule actions is covered at all ATM). Otherwise >> I feel like this is OK to commit. > +1 for adding at least two queries reported on this thread to regression= tests. Right, pushed with some test cases. regards, tom lane