Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1j7io5-00020c-W9 for pgsql-bugs@arkaria.postgresql.org; Fri, 28 Feb 2020 16:48:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1j7io4-0000Lx-N8 for pgsql-bugs@arkaria.postgresql.org; Fri, 28 Feb 2020 16:48:08 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j7io4-0000Lq-Eh for pgsql-bugs@lists.postgresql.org; Fri, 28 Feb 2020 16:48:08 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j7inw-00015O-Qe; Fri, 28 Feb 2020 16:48:08 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 01SGlqoN017655; Fri, 28 Feb 2020 11:47:52 -0500 From: Tom Lane To: Philip Semanchuk cc: Dave Page , Simon Riggs , Sergei Kornilov , "pgsql-bugs@lists.postgresql.org" Subject: Re: BUG #16279: Permissions doc incorrect for pg_buffercache In-reply-to: <6BCF9107-2559-495E-80B8-346921900796@americanefficient.com> References: <16279-fcaac33c68aab0ab@postgresql.org> <21009351582737086@iva6-22e79380f52c.qloud-c.yandex.net> <21597.1582839094@sss.pgh.pa.us> <6BCF9107-2559-495E-80B8-346921900796@americanefficient.com> Comments: In-reply-to Philip Semanchuk message dated "Thu, 27 Feb 2020 16:39:04 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <17653.1582908472.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Fri, 28 Feb 2020 11:47:52 -0500 Message-ID: <17654.1582908472@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Philip Semanchuk writes: >> On Feb 27, 2020, at 4:31 PM, Tom Lane wrote: >> Looking at the original discussion, it seems clear that the choice of >> pg_monitor was intentional; see in particular >> https://www.postgresql.org/message-id/CA%2BOCxowV7eL-DS1Hr-h5N7Tr8Gvn5V= GW%2B%2BYJ2yo6wMN9H3n9Gg%40mail.gmail.com >> So I think the code is correct and the documentation is a typo. >> That's a much easier answer to back-patch, as well. > Sounds good to me. Thanks for the context! Re-reading the pg_buffercache documentation, I was reminded that that view can have a pretty significant performance hit if you've got lots of shared buffers. So I think being restrictive about it is good policy, reinforcing the view that the code made the right choice. I pushed a patch fixing the docs, in v10 and up. regards, tom lane