Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sgm2I-007eGP-21 for pgsql-bugs@arkaria.postgresql.org; Wed, 21 Aug 2024 14:10:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sgm2F-00BaOy-Ow for pgsql-bugs@arkaria.postgresql.org; Wed, 21 Aug 2024 14:10:04 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sgm2F-00BaOo-Gz for pgsql-bugs@lists.postgresql.org; Wed, 21 Aug 2024 14:10:04 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sgm2D-000k3X-M9 for pgsql-bugs@postgresql.org; Wed, 21 Aug 2024 14:10:02 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 47LE9wCR1773684; Wed, 21 Aug 2024 10:09:58 -0400 From: Tom Lane To: Richard Guo cc: Peter Eisentraut , pgsql-bugs Subject: Re: CREATE CAST allows creation of binary-coercible cast to range over domain In-reply-to: References: <076968e1-0852-40a9-bc0b-117cd3f0e43c@eisentraut.org> <1537781.1724165175@sss.pgh.pa.us> <1611527.1724175039@sss.pgh.pa.us> <2e7acd5f-5d34-4802-a5e2-fa36433d133c@eisentraut.org> Comments: In-reply-to Richard Guo message dated "Wed, 21 Aug 2024 15:55:30 +0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1773682.1724249398.1@sss.pgh.pa.us> Date: Wed, 21 Aug 2024 10:09:58 -0400 Message-ID: <1773683.1724249398@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Richard Guo writes: > I wonder if it would be better for readability to list these types in > the order we check them in the code, as we did previously, i.e.: The previous order seemed quite random to me, because enums aren't container types and the reason for excluding them isn't really the same. I thought about re-ordering the code to match the new comment, but desisted. We could do that though... regards, tom lane