From: Manu <manuelreyesbravo@gmail.com>
To: jian he <jian.universality@gmail.com>
Cc: Andrey Rachitskiy <pl0h0yp1@gmail.com>, zengman <zengman@halodbtech.com>,
 syzhong16 <syzhong16@gmail.com>,
 pgsql-bugs <pgsql-bugs@lists.postgresql.org>,
 Amit Langote <amitlangote09@gmail.com>
Subject: Re: BUG #19621: Unexpected results of JSON_VALUE with DEFAULT ON
 EMPTY
Date: Sat, 26 Sep 2026 15:14:04 -0300
Message-ID: <179044644489.113031.11832692369228086606@gmail.com>
In-Reply-To: 
 <CACJufxFL-xzeD_GVVqbd1Jeab8unkbibM_=1cLBUASyi2bDx=g@mail.gmail.com>
References: 
 <CACJufxFL-xzeD_GVVqbd1Jeab8unkbibM_=1cLBUASyi2bDx=g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1084577088404425683=="
Archived-At: 
 <https://www.postgresql.org/message-id/179044644489.113031.11832692369228086606%40gmail.com>
Precedence: bulk

--===============1084577088404425683==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

Hi jian,

> This seems unnecessary.
> In EEOP_JSONEXPR_PATH, we can
> if document or jsonpath is NULL, we can just go to jump_end (return
> NULL) or jump_eval_coercion (NULL need coerce to constrainted domain),
> no need to worry about ON ERROR, ON EMPTY.

That also takes care of the back-branch concern I raised on v2: with
no new opcode, v3 does not change any header, so the ExprEvalOp values
stay as they are.

v3 applies cleanly to master, REL_18_STABLE and REL_17_STABLE, builds
without warnings, and the main regression suite passes on all three.

Since the bug is state leaking from one row to the next, I also
checked it with a differential test (attached): every row of a
two-row query must give the same result as that row evaluated alone.
It covers json_value (RETURNING int, a NOT NULL domain and a CHECK
domain), json_query and json_exists, with every ON EMPTY / ON ERROR
combination, over every ordered pair of rows built from five
documents ('{}', '{"a":1}', '{"a":"x"}', '{"a":[1,2]}', NULL) and
three paths ('$.a', 'strict $.a', NULL).  That is 9675 cases:

- unpatched master (09a579abaca): 567 mismatches (497 json_value,
  56 json_query, 14 json_exists)
- v3 on master, REL_18_STABLE and REL_17_STABLE: 0

The single-row answers do not change: all 645 of them are the same
with and without v3, including NULL input into the NOT NULL domain.

With Srinath's fix for #19695 on top, its case is right too
(1, NULL, 2).  As before, I could not exercise JIT here.

Regards,
Manu

--===============1084577088404425683==
Content-Type: text/plain
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="rows_oracle.sql.txt"
MIME-Version: 1.0

LS0gRGlmZmVyZW50aWFsIGNoZWNrIGZvciBKc29uRXhwciBzdGF0ZSBsZWFraW5nIGZyb20gb25l
IHJvdyB0byB0aGUgbmV4dAotLSAoIzE5NjIxLCAjMTk2NTQpLiAgT3JhY2xlOiBpbiBhIG11bHRp
LXJvdyBxdWVyeSwgdGhlIHJlc3VsdCBmb3IgZWFjaCByb3cKLS0gbXVzdCBiZSB0aGUgb25lIHRo
YXQgc2FtZSByb3cgZ2l2ZXMgd2hlbiBldmFsdWF0ZWQgYWxvbmUuICBJZiBhbnkgcm93Ci0tIGVy
cm9ycyB3aGVuIGFsb25lLCB0aGUgbXVsdGktcm93IHF1ZXJ5IG11c3QgZmFpbCB3aXRoIHRoZSBm
aXJzdCBzdWNoCi0tIGVycm9yIChWQUxVRVMgaXMgc2Nhbm5lZCBpbiBvcmRlcikuCi0tCi0tIE1h
dHJpeDoganNvbl92YWx1ZSAoUkVUVVJOSU5HIGludCwgYSBOT1QgTlVMTCBkb21haW4sIGEgQ0hF
Q0sgZG9tYWluKSB4Ci0tIE9OIEVNUFRZIHggT04gRVJST1IsIGpzb25fcXVlcnkgeCBPTiBFTVBU
WSB4IE9OIEVSUk9SLCBqc29uX2V4aXN0cyB4Ci0tIE9OIEVSUk9SOyBvdmVyIGV2ZXJ5IG9yZGVy
ZWQgcGFpciBvZiByb3dzLCB3aGVyZSBhIHJvdyBpcyBhIGRvY3VtZW50Ci0tICgne30nLCAneyJh
IjoxfScsICd7ImEiOiJ4In0nLCAneyJhIjpbMSwyXX0nLCBOVUxMKSBhbmQgYSBwYXRoCi0tICgn
JC5hJywgJ3N0cmljdCAkLmEnLCBOVUxMKS4KXHNldCBRVUlFVCBvbgpTRVQgY2xpZW50X21pbl9t
ZXNzYWdlcyA9IHdhcm5pbmc7CkRST1AgRE9NQUlOIElGIEVYSVNUUyBvX25uLCBvX3BvcyBDQVND
QURFOwpDUkVBVEUgRE9NQUlOIG9fbm4gQVMgaW50IE5PVCBOVUxMOwpDUkVBVEUgRE9NQUlOIG9f
cG9zIEFTIGludCBDSEVDSyAoVkFMVUUgPiAwKTsKCkNSRUFURSBURU1QIFRBQkxFIG9faXRlbSAo
aSBpbnQsIGQgdGV4dCwgcCB0ZXh0KTsKSU5TRVJUIElOVE8gb19pdGVtClNFTEVDVCByb3dfbnVt
YmVyKCkgT1ZFUiAoKSwgZCwgcAogIEZST00gdW5uZXN0KEFSUkFZWycnJ3t9JycnLCAnJyd7ImEi
OjF9JycnLCAnJyd7ImEiOiJ4In0nJycsICcnJ3siYSI6WzEsMl19JycnLCAnTlVMTCddKSBkLAog
ICAgICAgdW5uZXN0KEFSUkFZWycnJyQuYScnJywgJycnc3RyaWN0ICQuYScnJywgJ05VTEwnXSkg
cDsKCkNSRUFURSBURU1QIFRBQkxFIG9fZXhwciAoZSB0ZXh0KTsKSU5TRVJUIElOVE8gb19leHBy
ClNFTEVDVCBmb3JtYXQoJ2pzb25fdmFsdWUoeCwgcCBSRVRVUk5JTkcgJXMgJXMgT04gRU1QVFkg
JXMgT04gRVJST1IpJywgdCwgb2UsIG9lcikKICBGUk9NIHVubmVzdChBUlJBWVsnaW50JywgJ29f
bm4nLCAnb19wb3MnXSkgdCwKICAgICAgIHVubmVzdChBUlJBWVsnTlVMTCcsICdERUZBVUxUIDQy
JywgJ0VSUk9SJ10pIG9lLAogICAgICAgdW5uZXN0KEFSUkFZWydOVUxMJywgJ0RFRkFVTFQgNycs
ICdFUlJPUiddKSBvZXIKVU5JT04gQUxMClNFTEVDVCBmb3JtYXQoJ2pzb25fcXVlcnkoeCwgcCAl
cyBPTiBFTVBUWSAlcyBPTiBFUlJPUiknLCBvZSwgb2VyKQogIEZST00gdW5uZXN0KEFSUkFZWydO
VUxMJywgJ0VNUFRZIEFSUkFZJywgJ0RFRkFVTFQgJyciZCInJycsICdFUlJPUiddKSBvZSwKICAg
ICAgIHVubmVzdChBUlJBWVsnTlVMTCcsICdFTVBUWSBPQkpFQ1QnLCAnRVJST1InXSkgb2VyClVO
SU9OIEFMTApTRUxFQ1QgZm9ybWF0KCdqc29uX2V4aXN0cyh4LCBwICVzIE9OIEVSUk9SKScsIG9l
cikKICBGUk9NIHVubmVzdChBUlJBWVsnRkFMU0UnLCAnVFJVRScsICdVTktOT1dOJywgJ0VSUk9S
J10pIG9lcjsKCkNSRUFURSBURU1QIFRBQkxFIG9fcmVzdWx0IChlIHRleHQsIHJvd3MgdGV4dCwg
YWxvbmUgdGV4dCwgdG9nZXRoZXIgdGV4dCk7CgpETyAkJApERUNMQVJFCiAgZXggcmVjb3JkOyBh
IHJlY29yZDsgYiByZWNvcmQ7CiAgcjEgdGV4dDsgcjIgdGV4dDsgdG9nZXRoZXIgdGV4dDsgYWxv
bmUgdGV4dDsKICBxIHRleHQ7CkJFR0lOCiAgRk9SIGV4IElOIFNFTEVDVCBlIEZST00gb19leHBy
IExPT1AKICAgIEZPUiBhIElOIFNFTEVDVCAqIEZST00gb19pdGVtIExPT1AKICAgICAgRk9SIGIg
SU4gU0VMRUNUICogRlJPTSBvX2l0ZW0gTE9PUAogICAgICAgIC0tIGVhY2ggcm93IGFsb25lCiAg
ICAgICAgQkVHSU4KICAgICAgICAgIEVYRUNVVEUgZm9ybWF0KCdTRUxFQ1QgY29hbGVzY2UoKCVz
KTo6dGV4dCwgJydOVUxMJycpIEZST00gKFZBTFVFUyAoJXM6Ompzb25iLCAlczo6anNvbnBhdGgp
KSB2KHgsIHApJywKICAgICAgICAgICAgICAgICAgICAgICAgIGV4LmUsIGEuZCwgYS5wKSBJTlRP
IHIxOwogICAgICAgIEVYQ0VQVElPTiBXSEVOIE9USEVSUyBUSEVOIHIxIDo9ICdFUlJPUjogJyB8
fCBTUUxFUlJNOwogICAgICAgIEVORDsKICAgICAgICBCRUdJTgogICAgICAgICAgRVhFQ1VURSBm
b3JtYXQoJ1NFTEVDVCBjb2FsZXNjZSgoJXMpOjp0ZXh0LCAnJ05VTEwnJykgRlJPTSAoVkFMVUVT
ICglczo6anNvbmIsICVzOjpqc29ucGF0aCkpIHYoeCwgcCknLAogICAgICAgICAgICAgICAgICAg
ICAgICAgZXguZSwgYi5kLCBiLnApIElOVE8gcjI7CiAgICAgICAgRVhDRVBUSU9OIFdIRU4gT1RI
RVJTIFRIRU4gcjIgOj0gJ0VSUk9SOiAnIHx8IFNRTEVSUk07CiAgICAgICAgRU5EOwogICAgICAg
IGFsb25lIDo9IENBU0UgV0hFTiByMSBMSUtFICdFUlJPUjolJyBUSEVOIHIxCiAgICAgICAgICAg
ICAgICAgICAgICBXSEVOIHIyIExJS0UgJ0VSUk9SOiUnIFRIRU4gcjIKICAgICAgICAgICAgICAg
ICAgICAgIEVMU0UgcjEgfHwgJyB8ICcgfHwgcjIgRU5EOwogICAgICAgIC0tIGJvdGggcm93cyBp
biBvbmUgcXVlcnksIGluIG9yZGVyCiAgICAgICAgcSA6PSBmb3JtYXQoJ1NFTEVDVCBzdHJpbmdf
YWdnKGNvYWxlc2NlKCglcyk6OnRleHQsICcnTlVMTCcnKSwgJycgfCAnJyBPUkRFUiBCWSBvKQog
ICAgICAgICAgICAgICAgICAgICAgIEZST00gKFZBTFVFUyAoMSwgJXM6Ompzb25iLCAlczo6anNv
bnBhdGgpLCAoMiwgJXM6Ompzb25iLCAlczo6anNvbnBhdGgpKSB2KG8sIHgsIHApJywKICAgICAg
ICAgICAgICAgICAgICBleC5lLCBhLmQsIGEucCwgYi5kLCBiLnApOwogICAgICAgIEJFR0lOCiAg
ICAgICAgICBFWEVDVVRFIHEgSU5UTyB0b2dldGhlcjsKICAgICAgICBFWENFUFRJT04gV0hFTiBP
VEhFUlMgVEhFTiB0b2dldGhlciA6PSAnRVJST1I6ICcgfHwgU1FMRVJSTTsKICAgICAgICBFTkQ7
CiAgICAgICAgSU5TRVJUIElOVE8gb19yZXN1bHQgVkFMVUVTIChleC5lLCBhLmQgfHwgJywnIHx8
IGEucCB8fCAnICB0aGVuICAnIHx8IGIuZCB8fCAnLCcgfHwgYi5wLCBhbG9uZSwgdG9nZXRoZXIp
OwogICAgICBFTkQgTE9PUDsKICAgIEVORCBMT09QOwogIEVORCBMT09QOwpFTkQgJCQ7CgpTRUxF
Q1QgJ2Nhc2VzPScgfHwgY291bnQoKikgfHwgJyBtaXNtYXRjaGVzPScgfHwgY291bnQoKikgRklM
VEVSIChXSEVSRSBhbG9uZSBJUyBESVNUSU5DVCBGUk9NIHRvZ2V0aGVyKQogIEZST00gb19yZXN1
bHQ7ClNFTEVDVCBzcGxpdF9wYXJ0KGUsICcoJywgMSkgQVMgZnVuYywgY291bnQoKikgRklMVEVS
IChXSEVSRSBhbG9uZSBJUyBESVNUSU5DVCBGUk9NIHRvZ2V0aGVyKSBBUyBtaXNtYXRjaGVzLCBj
b3VudCgqKSBBUyBjYXNlcwogIEZST00gb19yZXN1bHQgR1JPVVAgQlkgMSBPUkRFUiBCWSAxOwpT
RUxFQ1QgZSwgcm93cywgYWxvbmUsIHRvZ2V0aGVyCiAgRlJPTSBvX3Jlc3VsdCBXSEVSRSBhbG9u
ZSBJUyBESVNUSU5DVCBGUk9NIHRvZ2V0aGVyCiBPUkRFUiBCWSBlLCByb3dzIExJTUlUIDg7Cg==

--===============1084577088404425683==--