Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xH40R-00000002nyM-18jb for pgsql-bugs@arkaria.postgresql.org; Wed, 14 Oct 2026 18:47:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xH40Q-000000050rc-0XX2 for pgsql-bugs@arkaria.postgresql.org; Wed, 14 Oct 2026 18:47:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xH40P-000000050rU-3Tup for pgsql-bugs@lists.postgresql.org; Wed, 14 Oct 2026 18:47:13 +0000 Received: from mail-dy1-x1332.google.com ([2607:f8b0:4864:20::1332]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1xH40N-000000027Eq-2PMs for pgsql-bugs@lists.postgresql.org; Wed, 14 Oct 2026 18:47:13 +0000 Received: by mail-dy1-x1332.google.com with SMTP id 5a478bee46e88-35159e0092aso507221eec.2 for ; Wed, 14 Oct 2026 11:47:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792003628; x=1792608428; darn=lists.postgresql.org; h=content-type:mime-version:references:in-reply-to:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JKzP6QoY37JH+A0R3+WsFNKcG14xB1y6oazyef0sicM=; b=CXk9Vn19iTE6iLxqOrPNjP1JAtZkK61tF3EN24Tkn7ph7ifyWPcXHOe62fmERXSJVf qJvogps4zDvDy8K5lhVrWI6YbKQrLbEy0uD8bchWrFyB+Ixzhuc+jl+MIWxgi2STyE6k VZCrEKXv1RTwdJQBMGKm0QFlmSrXlX3h1c557pEJtpCXHtPgw+fs/tkNG9afGbun6pF0 9wiAZ9ZcJxR7NTdB9rSjBuRADJoSMU+2qVXh9Cj9rnOzq6hfNOMZTS270ge8TMyiDkYk ZMjTPNdcGsp1bwuLeOf5S2wCN1WmMMor2s7wKT2CHGUBANZQeSvwSqULbNqz5EzMpdGo t3Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792003628; x=1792608428; h=content-type:mime-version:references:in-reply-to:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=JKzP6QoY37JH+A0R3+WsFNKcG14xB1y6oazyef0sicM=; b=xDqVOML8Pgvms6ZEP6rv8khH+s9MUXC26+NjK3AjaaKqzPnGd5qwssBLbJMxC3DKlJ qavPmnepLWwpRLfoqwkEfVn/UqWEDpzgm46wHEbg/SJFheSUreUbNEDlD37kASBQ7G07 58Abzv+aSXwxWyCGtiL9tbPMRasalbnHUewBVyDQcC6z7ajHbZSph7kcKRNRI2wIXAr0 QDXDYtndMhazq7C3UYEpOm5EPEtIVqDeSXWiTMcorImW5V3VJQYVs87VC7FI/Ymcpfu+ Q5uWtqiaPxA+g4PQS2PnAxjq2zPyALBNdwX3lAhfMJV/CQyh6gaL9ZfSpasPJhB2j400 IB+g== X-Gm-Message-State: AFq9FYLZN5EHVB6MxUVat+lqUtiQxDHjxufWNVSqwNpsEulkmQ3659gF PM/c5vfFi248WL1r78dc29MBGwwlv/UZCYcFk/Gwfl2i5lRuke4Le4tu4sivgDoB X-Gm-Gg: AYBFou3Ry6E5gFDgxaltWsPPw8gKB0OQXiH8bupOvtzd3YnXTR3gq7CG/MPiRuPEYaT zrRGuJPrThWrA/gu7qbz5imRHo/X/TFWlN9kXaBQgzz5nFnLZ5yf68tZWYJDok3YfY/M11Xafgl R5xcwkB/8/CZc+xoWJpIWX0MdsO84SIxwts6PkjU3xM/HBy2KTTU3G+hh5JKK4BxJ2VMNuYNKNj miq+Pg6wgUF73a/cJXl6P1z/59rmhEPDa2PFUtEqCQIA6EPvmxWQlI8KAk3isYv9T5YTARcsbSL PiE4B7JiPr4uOdqQ5Z0ZJzjvIeD/+vP+44+9q55F4MOjKHDCM2InH4rQPMdvhzmP1DiABFtR4wy nSTY92zrZp/sqIrENJcyqBxsvjrSypCcCxIfcB0G1pbAg0hfDaGBzXVQCm0GrZxRyqPltM0w9jX Erh8ODRNeYffzYKcv8VilSr5N762MtiVLV0vbcWwCyy+XiRXy2eVYs4vVKw0nGGDZSWSKX854cQ 9MgC1uyuD9EbxtpcYs0nPeM4QeEg3VOB7aVqCRviD5/7ZYIJr1SDrraOw5TTR/DT8krbKkukWHV 4WIoWktrZhFzf8R69Hp6PA== X-Received: by 2002:a05:7301:4d07:b0:35e:9cb2:b88a with SMTP id 5a478bee46e88-35e9cc1fcd5mr2278152eec.2.1792003627615; Wed, 14 Oct 2026 11:47:07 -0700 (PDT) Received: from 192.168.1.109 ([190.12.171.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-358ee8a3387sm45853555eec.15.2026.10.14.11.47.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2026 11:47:06 -0700 (PDT) From: Manu To: pgsql-bugs@lists.postgresql.org Cc: Staroverov Ilja Subject: Re: VACUUM/ANALYZE double-count the backend's own pending table stats Date: Wed, 14 Oct 2026 15:47:04 -0300 Message-ID: <179200362437.252424.7000490135467740876@gmail.com> In-Reply-To: <1DC9D815-8754-4A76-B2B1-99C1A614A55A@localhost.localdomain> References: <1DC9D815-8754-4A76-B2B1-99C1A614A55A@localhost.localdomain> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3431494251516971542==" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --===============3431494251516971542== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Hi Ilya, I reproduced v1 and stress-tested it: it holds up. 8000 randomized single-session sequences (lazy vs eager flush as the oracle), plus 2PC, the truncdropped paths and post-snapshot inserts all match count(*) with the patch. Nice work. One thing, which is the corner you already called out: > One thing this patch doesn't fix: after INSERT + VACUUM in the same > session, ins_since_vacuum is still N, because the flush adds the > pending tuples_inserted to it. It is the same double count your patch fixes for live/dead, in the same function, and it does fire a spurious insert-triggered autovacuum right after a manual VACUUM. Minimal: INSERT 1000; VACUUM t; SELECT pg_stat_force_next_flush(); -- n_ins_since_vacuum = 1000, should be 0 The attached delta sits on top of yours, untouched; it applies clean (+18/-8) and closes it: a pending ins_before_vacuum field, appended at the end of the struct so the inline pgstat_count_* offsets do not move (keeps a back-branch fix viable). pgstat_report_vacuum() records what it already covered; the flush adds only the difference, so tuples_inserted and n_tup_ins stay cumulative. make check is green and the oracle drops to zero failures (minus TRUNCATE, below). Fold it into v2 if you like, or I can post it as a separate 0002. Two pre-existing things the oracle flagged that predate your patch (same on unpatched master, so not v1's doing): pending inserts before a TRUNCATE, and n_dead_tup after a subxact rolled back past a TRUNCATE. Both look like they need the truncdrop save/restore across subtransactions. Happy to send the repros separately if useful. Regards, Manu --===============3431494251516971542== Content-Type: text/x-patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="ins-since-vacuum.diff" MIME-Version: 1.0 ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3V0aWxzL2FjdGl2aXR5L3Bnc3RhdF9yZWxhdGlvbi5j IGIvc3JjL2JhY2tlbmQvdXRpbHMvYWN0aXZpdHkvcGdzdGF0X3JlbGF0aW9uLmMKaW5kZXggY2Zl YmQwY2Q2ZGQuLjllNjU1OTU5NmU3IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC91dGlscy9hY3Rp dml0eS9wZ3N0YXRfcmVsYXRpb24uYworKysgYi9zcmMvYmFja2VuZC91dGlscy9hY3Rpdml0eS9w Z3N0YXRfcmVsYXRpb24uYwpAQCAtMjc5LDYgKzI3OSwxMSBAQCBwZ3N0YXRfcmVwb3J0X3ZhY3V1 bShSZWxhdGlvbiByZWwsIFBnU3RhdF9Db3VudGVyIGxpdmV0dXBsZXMsCiAJICogc3RhdHMgaGF2 ZSBub3QgYmVlbiBmbHVzaGVkIHlldC4gIEZvcmdldCB0aGUgcGVuZGluZyBkZWx0YXMgZm9yIHRo b3NlCiAJICogY291bnRlcnMsIGVsc2UgdGhleSB3b3VsZCBiZSBhZGRlZCBvbiB0b3Agb2YgdGhl IG5ldyB2YWx1ZXMgYXQgdGhlCiAJICogbmV4dCBmbHVzaC4gIEEgcGVuZGluZyB0cnVuY2F0aW9u IHJlc2V0IGlzIHN1cGVyc2VkZWQgYXMgd2VsbC4KKwkgKgorCSAqIExpa2V3aXNlLCB0aGUgcGVu ZGluZyBpbnNlcnRzIG11c3Qgbm90IGNvdW50IHRvd2FyZHMgaW5zX3NpbmNlX3ZhY3V1bSwKKwkg KiB3aGljaCBpcyByZXNldCBiZWxvdy4gIFdlIGNhbid0IGp1c3QgemVybyB0dXBsZXNfaW5zZXJ0 ZWQsIHdoaWNoIGFsc28KKwkgKiBmZWVkcyB0aGUgY3VtdWxhdGl2ZSB0dXBsZXNfaW5zZXJ0ZWQg Y291bnRlciwgc28gcmVtZW1iZXIgaG93IG1hbnkgb2YKKwkgKiB0aGVtIHRoZSBmbHVzaCBoYXMg dG8gc2tpcC4KIAkgKi8KIAlpZiAocGdzdGF0X3Nob3VsZF9jb3VudF9yZWxhdGlvbihyZWwpKQog CXsKQEAgLTI4OCw2ICsyOTMsOCBAQCBwZ3N0YXRfcmVwb3J0X3ZhY3V1bShSZWxhdGlvbiByZWws IFBnU3RhdF9Db3VudGVyIGxpdmV0dXBsZXMsCiAJCXBlbmRpbmctPnRhYi5jb3VudHNfeGFjdC5k ZWx0YV9saXZlX3R1cGxlcyA9IDA7CiAJCXBlbmRpbmctPnRhYi5jb3VudHNfeGFjdC5kZWx0YV9k ZWFkX3R1cGxlcyA9IDA7CiAJCXBlbmRpbmctPnRhYi50cnVuY2Ryb3BwZWQgPSBmYWxzZTsKKwkJ cGVuZGluZy0+dGFiLmluc19iZWZvcmVfdmFjdXVtID0KKwkJCXBlbmRpbmctPnRhYi5jb3VudHNf eGFjdC50dXBsZXNfaW5zZXJ0ZWQ7CiAJfQogCiAJLyogU3RvcmUgdGhlIGRhdGEgaW4gdGhlIHRh YmxlJ3MgaGFzaCB0YWJsZSBlbnRyeS4gKi8KQEAgLTk5Myw3ICsxMDAwLDggQEAgcGdzdGF0X3Jl bGF0aW9uX2ZsdXNoX2NiKFBnU3RhdF9FbnRyeVJlZiAqZW50cnlfcmVmLCBib29sIG5vd2FpdCkK IAkgKiB0cmlnZ2VyaW5nIGZvciBpbnNlcnRzIG1vcmUgb2Z0ZW4gdGhhbiB0aGV5IG1heWJlIHNo b3VsZCwgd2hpY2ggaXMKIAkgKiBwcm9iYWJseSBub3QgZ29pbmcgdG8gYmUgY29tbW9uIGVub3Vn aCB0byBiZSB0b28gY29uY2VybmVkIGFib3V0IGhlcmUuCiAJICovCi0JdGFiZW50cnktPmluc19z aW5jZV92YWN1dW0gKz0gbHN0YXRzLT50YWIuY291bnRzX3hhY3QudHVwbGVzX2luc2VydGVkOwor CXRhYmVudHJ5LT5pbnNfc2luY2VfdmFjdXVtICs9IGxzdGF0cy0+dGFiLmNvdW50c194YWN0LnR1 cGxlc19pbnNlcnRlZCAtCisJCWxzdGF0cy0+dGFiLmluc19iZWZvcmVfdmFjdXVtOwogCiAJdGFi ZW50cnktPmJsb2Nrc19mZXRjaGVkICs9IGxzdGF0cy0+dGFiLmNvdW50cy5ibG9ja3NfZmV0Y2hl ZDsKIAl0YWJlbnRyeS0+YmxvY2tzX2hpdCArPSBsc3RhdHMtPnRhYi5jb3VudHMuYmxvY2tzX2hp dDsKZGlmZiAtLWdpdCBhL3NyYy9pbmNsdWRlL3Bnc3RhdC5oIGIvc3JjL2luY2x1ZGUvcGdzdGF0 LmgKaW5kZXggMTg3ZDgyYzk2ZmUuLjZiNmE3MDVhYmE1IDEwMDY0NAotLS0gYS9zcmMvaW5jbHVk ZS9wZ3N0YXQuaAorKysgYi9zcmMvaW5jbHVkZS9wZ3N0YXQuaApAQCAtMjM2LDYgKzIzNiw4IEBA IHR5cGVkZWYgc3RydWN0IFBnU3RhdF9SZWxhdGlvblN0YXR1cwogCQkJc3RydWN0IFBnU3RhdF9U YWJsZVhhY3RTdGF0dXMgKnRyYW5zOwkvKiBsb3dlc3Qgc3VieGFjdCdzIGNvdW50cyAqLwogCQkJ UGdTdGF0X1RhYmxlQ291bnRzIGNvdW50czsJLyogZXZlbnQgY291bnRzIHRvIGJlIHNlbnQgKi8K IAkJCVBnU3RhdF9UYWJsZUNvdW50c1hhY3QgY291bnRzX3hhY3Q7IC8qIHRyYW5zYWN0aW9uYWwg Y291bnRzICovCisJCQkvKiBwZW5kaW5nIHR1cGxlc19pbnNlcnRlZCBhbHJlYWR5IGNvdmVyZWQg YnkgYSBWQUNVVU0gKi8KKwkJCVBnU3RhdF9Db3VudGVyIGluc19iZWZvcmVfdmFjdXVtOwogCQl9 CQkJdGFiOwogCiAJCS8qIGluZGV4IGNvdW50ZXJzICovCmRpZmYgLS1naXQgYS9zcmMvdGVzdC9y ZWdyZXNzL2V4cGVjdGVkL3N0YXRzLm91dCBiL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvc3Rh dHMub3V0CmluZGV4IDVlMjhkYjZlNTdkLi4xNTRiOTlhNGMxMiAxMDA2NDQKLS0tIGEvc3JjL3Rl c3QvcmVncmVzcy9leHBlY3RlZC9zdGF0cy5vdXQKKysrIGIvc3JjL3Rlc3QvcmVncmVzcy9leHBl Y3RlZC9zdGF0cy5vdXQKQEAgLTMyMiwxNCArMzIyLDE0IEBAIFNFTEVDVCBwZ19zdGF0X2ZvcmNl X25leHRfZmx1c2goKTsKICAKICgxIHJvdykKIAotU0VMRUNUIHJlbG5hbWUsIG5fbGl2ZV90dXAs IG5fZGVhZF90dXAsIG5fbW9kX3NpbmNlX2FuYWx5emUKK1NFTEVDVCByZWxuYW1lLCBuX2xpdmVf dHVwLCBuX2RlYWRfdHVwLCBuX21vZF9zaW5jZV9hbmFseXplLCBuX2luc19zaW5jZV92YWN1dW0K ICAgRlJPTSBwZ19zdGF0X3VzZXJfdGFibGVzCiAgV0hFUkUgcmVsbmFtZSBMSUtFICdzdGF0c19w ZW5kaW5nXyUnIE9SREVSIEJZIHJlbG5hbWU7Ci0gICAgICAgIHJlbG5hbWUgICAgICAgIHwgbl9s aXZlX3R1cCB8IG5fZGVhZF90dXAgfCBuX21vZF9zaW5jZV9hbmFseXplIAotLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0rLS0tLS0tLS0tLS0tKy0tLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0tLS0tLS0t LS0KLSBzdGF0c19wZW5kaW5nX2FuYWx5emUgfCAgICAgICAgICA2IHwgICAgICAgICAgNCB8ICAg ICAgICAgICAgICAgICAgIDAKLSBzdGF0c19wZW5kaW5nX3RydW5jICAgfCAgICAgICAgICAzIHwg ICAgICAgICAgMCB8ICAgICAgICAgICAgICAgICAgMTMKLSBzdGF0c19wZW5kaW5nX3ZhY3V1bSAg fCAgICAgICAgIDEwIHwgICAgICAgICAgMCB8ICAgICAgICAgICAgICAgICAgMTAKKyAgICAgICAg cmVsbmFtZSAgICAgICAgfCBuX2xpdmVfdHVwIHwgbl9kZWFkX3R1cCB8IG5fbW9kX3NpbmNlX2Fu YWx5emUgfCBuX2luc19zaW5jZV92YWN1dW0gCistLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSstLS0t LS0tLS0tLS0rLS0tLS0tLS0tLS0tKy0tLS0tLS0tLS0tLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0t LS0tLS0tLQorIHN0YXRzX3BlbmRpbmdfYW5hbHl6ZSB8ICAgICAgICAgIDYgfCAgICAgICAgICA0 IHwgICAgICAgICAgICAgICAgICAgMCB8ICAgICAgICAgICAgICAgICAxMAorIHN0YXRzX3BlbmRp bmdfdHJ1bmMgICB8ICAgICAgICAgIDMgfCAgICAgICAgICAwIHwgICAgICAgICAgICAgICAgICAx MyB8ICAgICAgICAgICAgICAgICAgMworIHN0YXRzX3BlbmRpbmdfdmFjdXVtICB8ICAgICAgICAg MTAgfCAgICAgICAgICAwIHwgICAgICAgICAgICAgICAgICAxMCB8ICAgICAgICAgICAgICAgICAg MAogKDMgcm93cykKIAogRFJPUCBUQUJMRSBzdGF0c19wZW5kaW5nX3RydW5jLCBzdGF0c19wZW5k aW5nX2FuYWx5emUsIHN0YXRzX3BlbmRpbmdfdmFjdXVtOwpkaWZmIC0tZ2l0IGEvc3JjL3Rlc3Qv cmVncmVzcy9zcWwvc3RhdHMuc3FsIGIvc3JjL3Rlc3QvcmVncmVzcy9zcWwvc3RhdHMuc3FsCmlu ZGV4IDMwMmZmOWFmMDVjLi5iN2I0NTcwZTVhMyAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvcmVncmVz cy9zcWwvc3RhdHMuc3FsCisrKyBiL3NyYy90ZXN0L3JlZ3Jlc3Mvc3FsL3N0YXRzLnNxbApAQCAt MTczLDcgKzE3Myw3IEBAIEFOQUxZWkUgc3RhdHNfcGVuZGluZ19hbmFseXplOwogSU5TRVJUIElO VE8gc3RhdHNfcGVuZGluZ192YWN1dW0gU0VMRUNUIGdlbmVyYXRlX3NlcmllcygxLCAxMCk7CiBW QUNVVU0gc3RhdHNfcGVuZGluZ192YWN1dW07CiBTRUxFQ1QgcGdfc3RhdF9mb3JjZV9uZXh0X2Zs dXNoKCk7Ci1TRUxFQ1QgcmVsbmFtZSwgbl9saXZlX3R1cCwgbl9kZWFkX3R1cCwgbl9tb2Rfc2lu Y2VfYW5hbHl6ZQorU0VMRUNUIHJlbG5hbWUsIG5fbGl2ZV90dXAsIG5fZGVhZF90dXAsIG5fbW9k X3NpbmNlX2FuYWx5emUsIG5faW5zX3NpbmNlX3ZhY3V1bQogICBGUk9NIHBnX3N0YXRfdXNlcl90 YWJsZXMKICBXSEVSRSByZWxuYW1lIExJS0UgJ3N0YXRzX3BlbmRpbmdfJScgT1JERVIgQlkgcmVs bmFtZTsKIERST1AgVEFCTEUgc3RhdHNfcGVuZGluZ190cnVuYywgc3RhdHNfcGVuZGluZ19hbmFs eXplLCBzdGF0c19wZW5kaW5nX3ZhY3V1bTsK --===============3431494251516971542==--