Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xJzeH-00000000Y5I-1tli for pgsql-bugs@arkaria.postgresql.org; Thu, 22 Oct 2026 20:44:30 +0000 Received: from localhost ([127.0.0.1]:54342 helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xJzeF-0000000DKa2-0Z7V for pgsql-bugs@arkaria.postgresql.org; Thu, 22 Oct 2026 20:44:27 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]:46302) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xJzeE-0000000DKZt-2FdJ for pgsql-bugs@lists.postgresql.org; Thu, 22 Oct 2026 20:44:26 +0000 Received: from mail-vs1-xe2c.google.com ([2607:f8b0:4864:20::e2c]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1xJzeB-00000000SgU-3ygF for pgsql-bugs@lists.postgresql.org; Thu, 22 Oct 2026 20:44:25 +0000 Received: by mail-vs1-xe2c.google.com with SMTP id ada2fe7eead31-7c05859ec4dso3726137.2 for ; Thu, 22 Oct 2026 13:44:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792701862; x=1793306662; darn=lists.postgresql.org; h=content-type:mime-version:references:in-reply-to:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kE+E9Nc7zwCEeTHNi5UMJ/Fb6OWrBITihagtEmOVqY0=; b=Ma9DYADxmIlE9ISJVSYXS/kwHT3uptEN0l2lGg6gg2JPCxtYRVkKZRiSEx90rPcdhl Up2B0onjF2da+iXb46iQx9q9LKx8zCPOw/h0UwXKk9rr3PdbmWXBrdRJHcrQX04Uysxv YcxITMU3Y39pP61pNPTTn4ujC2EDFVcgOE30tgBKPknsRG7SRyVM808QTlAXpIbprH2y DdFk6sykinf7k8VEpmFWUMjnz9m+fMr+TIq90+MNMx+LjD6y26NPxcxzyuHjSCOn0LVO c1oAM/iTIxTCvDZ+XxuFsmO9gtuXgrXAuxDJtVWzZIl6z5/Sxcw3FqzUAOteFM7+62VY orEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792701862; x=1793306662; h=content-type:mime-version:references:in-reply-to:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=kE+E9Nc7zwCEeTHNi5UMJ/Fb6OWrBITihagtEmOVqY0=; b=cIoHO6HdjyDWDL6V9RAsNieZSuAjzfz2NW+FEsFTHS1V1M5etJ6B/xSLy/b82YSCVG ySjE6PHTwZr4mlqEvLpYPHy0bpQkkXlP5zVl4snBtwb6z8NtfkguTiBGIC4s0hlJKFUh BhR+5tqTu5yrctVWyWeHPfsD3mpYhf1+wieBbBGYUM1jzYND+Wdw85HPQ19Cb4RKnyCw G318BW3Z56qVZHt15MAIp/2Rv1iHljsiWcezgu2LAZQioBNcUwBKSKjumGORBB/7XWVI Bod/jPdxpldoK8FuqsP6Ezc+BYxkJPUSyfcgGFqBIMJZfZRN2PHcU8+qcPniEvF1xRqQ P8HQ== X-Forwarded-Encrypted: i=1; AKwUvByhwDJ0JEHjoePQ1rMSTWxexps0tEXXmRBOXjpBXCS457nvuWD0TVIvZLoSowPSqVoY0SpBrZOznQ9o@lists.postgresql.org X-Gm-Message-State: AFq9FYK3CV2GFkqustb4VKWjTnBD+1lKFnpdRCbzkSjIT5QVMhiCp3DX 2SHR+T0mFT3KBvV/+3E7U4kv1JDzqMj+9vXJG1sqybe1rWS/33aPrxBx X-Gm-Gg: AYBFou0rUAvEPS1mGyD8b3/Abm5ZGSsDo5Ih7duV6k6JrrzmTLyYKs3r5x5z68uZd/F xUy+WTa6nFGeLsyT0s/lJGwrnM5ukjOceugKVZu09tGMVzwNeJeQ7O6x5ciQZsXFB13AJfrjsPj dxI0n8dvNYB+s6ODgjpJ52CNSPvvMYVIc2T7DBRTVX3W0lTKItK1pOOqRWJTpFFyyjgK8e0ubsw EYzql5OfxHL//GbKqkVFaypwwjKSqOUOsNX2ROknYxydvRwMGQAruul5LRKvMV8GbnZDdSBXqbj unj5QFQ39OU9tdOKN24myeNKGAPYb40a9wAgcOjKzGPIQ7spLusUr9GRhIX9kmXeZtEq4/VGRij va4MsRdeupMDLdHzB7Um5ROwqunzfNFBojPcqWe1iF6A7jIvWUthOdqVElNn+mXsgPlmNk4qwBF 82TJ/xa+Wc7zXDSWIN006/tHHvVrJIyqG7oi+843EzMKtcnI8hnJkmkSmfcPZASJi+u6Baoo0wl bxGKcnMwR4KqL8MGCj7L5V9xSyxrjvegxPpMPzKeHnz+KOs1kxELO7SFjT0SYfqkSd7xsYQiEjY qc2gLoNWQAZw92XD7cod3at2Akb+iaEBx1AwckjzdakEz/ZM83801pAVgO+vnZh9IKZRIVz+Xo+ 4XfFIMm0= X-Received: by 2002:a05:6102:a1c5:20b0:7b4:f1cd:80dd with SMTP id ada2fe7eead31-7ccc3096eb3mr250089137.1.1792701861827; Thu, 22 Oct 2026 13:44:21 -0700 (PDT) Received: from 192.168.1.109 ([2803:3c90:cee:ea00:5c3c:7e70:29e3:7a55]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-9910160bad4sm474880241.1.2026.10.22.13.44.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Oct 2026 13:44:21 -0700 (PDT) From: Manu To: Michael Paquier Cc: Zhijie Hou , shihao zhong , Takeshi Ideriha , Ayush Tiwari , alpkeles99@gmail.com, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #19760: CLUSTER loses a row the transaction inserted and then updated in a rolled-back subtransaction Date: Thu, 22 Oct 2026 17:44:14 -0300 Message-ID: <179270185475.2848856.14795062969027149847@gmail.com> In-Reply-To: References: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3810972130029512734==" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --===============3810972130029512734== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Hi Michael, On Thu, Oct 22, 2026 at 11:22:08AM +0900, Michael Paquier wrote: > The DELETE case is a much more common case. It regresses even more > badly, and that does not look acceptable to me. That should be > optimizable, of course, I don't really know yet how to do that. I ran your scripts as attached upthread, on master 871dee0ccbe with v2, 500k rows and 64 holders, 12 interleaved rounds per build. The ratios match yours: VACUUM takes 1.98x HEAD with delete.sql (95% CI 1.96..2.02) and 1.53x with subxact_updates.sql (1.51..1.55), and insert_only.sql does not move. Method and tables are in the attached measurements.txt. The two cases cost for different reasons. In delete.sql xmax is the inserter's own xid, so the new TransactionIdIsInProgress(xmax) is a second proc array scan, and pg_stat_slru shows no extra access. It grows with the number of open transactions: 1.51x with no holder, 1.95x with 16, 2.02x with 128. In subxact_updates.sql xmax is one of 500k subxids, the subxid cache has overflowed, and v2 doubles the pg_subtrans and clog accesses of each VACUUM (999872 to 1999744 for pg_subtrans, 499936 to 999872 for the clog). Zhijie's idea, doing the check only when xmin != xmax, removes the delete.sql regression: 1.00x (0.99..1.01). In delete.sql xmax and xmin are the same xid, so the check is skipped there. subxact_updates stays at 1.53x, as he expected. The condition the other way around loses the pg_class row again. On its own the idea keeps the MultiXact race of his repro; with the HEAP_XMAX_IS_MULTI skip you suggested, the repro passes. Both together are nocfbot-0001. For subxact_updates, nocfbot-0002 on top of it. In that branch xmin is in progress, so xmax is the inserter's xid or one of its subtransactions, and RecordTransactionAbort() writes a subtransaction abort to the clog before the xids leave the proc array. So TransactionIdDidAbort(xmax) gives the same answer there as !TransactionIdIsInProgress() && !TransactionIdDidCommit(), with one clog lookup and no proc array or pg_subtrans access. With both diffs, subxact_updates is at 1.01x (1.00..1.03) with 64 holders and 1.00x with 128. What 0002 costs is that clog lookup per tuple: 1.14x with no holder at all (50 ms to 57 ms). With 0001 alone and with 0001 + 0002, these pass: the v2-0002 spec, your pg_statistic sequence, VACUUM FULL pg_class with the CREATE TABLE transaction open, logical decoding across it, Zhijie's injection point repro, make check, isolation, and recovery 035. Since 0002 changes when the hint is set, I added five cases where the pg_class row must survive VACUUM FULL pg_class exactly once (released, nested and prepared subtransactions). A build that sets the hint unconditionally passes the original SQL cases and fails three of the new ones, with two pg_class rows for the table. The diffs apply on top of v2-0001 and v2-0002. Shihao, if they hold up, feel free to fold them into a v3. Regards, Manu --===============3810972130029512734== Content-Type: text/plain Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="measurements.txt" MIME-Version: 1.0 QlVHICMxOTc2MDogY29zdCBvZiB0aGUgc2Vjb25kIFNldEhpbnRCaXRzKCkgb2YgdjItMDAwMSwg YW5kIHR3bwpkaWZmcyBvbiB0b3Agb2YgdjIKClJ1biB3aXRoIE1pY2hhZWwncyBzY3JpcHRzIGZy b20gdXB0aHJlYWQsIGFzIGF0dGFjaGVkIHRoZXJlCihzZXR1cC5zcWwsIGhvbGRlcnMuc3FsLCBk ZWxldGUuc3FsLCBpbnNlcnRfb25seS5zcWwsCnN1YnhhY3RfdXBkYXRlcy5zcWwsIHZhY3V1bS5z cWwpLCB1bmNoYW5nZWQ6IDUwMGsgcm93cywgNjQgaG9sZGVycy4KCkJhc2U6IG1hc3RlciA4NzFk ZWUwY2NiZSwgcGx1cyB2Mi0wMDAxIGFuZCB2Mi0wMDAyIGZyb20gdXB0aHJlYWQuCkJ1aWxkczog Y29uZmlndXJlIC0tZW5hYmxlLWRlcGVuZCwgQ0ZMQUdTPS1PMiwgbm8gYXNzZXJ0aW9ucy4KTWFj aGluZTogUnl6ZW4gQUkgOSBIWCAzNzAgbGFwdG9wLCBydW5zIHBpbm5lZCB0byA0IFplbiA1IGNv cmVzCig4IHRocmVhZHMpOyBkYXRhIGRpcmVjdG9yeSBvbiB0bXBmcy4KU2VydmVyIHNldHRpbmdz OiBtYXhfY29ubmVjdGlvbnMgPSAyMDAsIGF1dG92YWN1dW0gPSBvZmYsCm1heF93YWxfc2l6ZSA9 IDI1Nk1CLCB0aGUgcmVzdCBkZWZhdWx0LgoKT25lIHNhbXBsZToKICBwc3FsIC1mIHNldHVwLnNx bAogIGZvciBpIGluICQoc2VxICRIKTsgZG8KICAgIHBzcWwgLVggLWYgaG9sZGVycy5zcWwgPiAv ZGV2L251bGwgMj4mMSAmCiAgZG9uZQogICh3YWl0IHVudGlsICRIIGJhY2tlbmRzIHNsZWVwIGlu IHBnX3NsZWVwKQogIHBzcWw6IFxpIDxsb2FkPi5zcWwgICAgICAgICAgLS0gbGVmdCBvcGVuCiAg Q0hFQ0tQT0lOVDsgU0VMRUNUIHBnX3N0YXRfcmVzZXRfc2xydSgpOwogIHBzcWwgLVggLWYgdmFj dXVtLnNxbCAgICAgICAgLS0gbWV0cmljOiBtZWFuIG9mIGl0cyA5IFZBQ1VVTSB0aW1lcwogIHJl YWQgcGdfc3RhdF9zbHJ1LCB0aGVuIHN0b3AgZXZlcnl0aGluZwpFYWNoIHJvdW5kIHJ1bnMgZXZl cnkgYnVpbGQgb25jZSwgaW4gYW4gb3JkZXIgcm90YXRlZCBwZXIgcm91bmQuCkEgc2FtcGxlIGlz IGRyb3BwZWQgYW5kIHJlZG9uZSBpZiBhIENQVSBjYWxpYnJhdGlvbiBsb29wIHJ1biBiZWZvcmUK YW5kIGFmdGVyIGl0IGlzIG1vcmUgdGhhbiA4JSBzbG93ZXIgdGhhbiBpdHMgaWRsZSB0aW1lLgpS ZXBvcnRlZDogbWVkaWFuIG9mIHRoZSBzYW1wbGVzLCByYXRpbyB0byBIRUFELCBib290c3RyYXAg OTUlIENJIG9mCnRoZSByYXRpbyBvZiBtZWRpYW5zICg0MDAwIHJlc2FtcGxlcykuCgpCdWlsZHM6 CiAgSEVBRCAgICAgICAgICAgICAgICAgIG1hc3RlcgogIHYyICAgICAgICAgICAgICAgICAgICB2 Mi0wMDAxICsgdjItMDAwMiBhcyBwb3N0ZWQKICB2MiAxc3QgaGludCBvbmx5ICAgICAgdjIgd2l0 aG91dCB0aGUgc2Vjb25kIFNldEhpbnRCaXRzKCkKICB2MiArIHNraXAgeG1heD09eG1pbiAgc2Vj b25kIGhpbnQgb25seSB3aGVuIHhtYXggIT0geG1pbgogIHYyICsgc2tpcCB4bWF4IT14bWluICBz ZWNvbmQgaGludCBvbmx5IHdoZW4geG1heCA9PSB4bWluCiAgdjIgKyBjYXRhbG9ncyBvbmx5ICAg IHNlY29uZCBoaW50IG9ubHkgaWYKICAgICAgICAgICAgICAgICAgICAgICAgSXNDYXRhbG9nUmVs YXRpb25PaWQoaHR1cC0+dF90YWJsZU9pZCkKICB2MiArIERpZEFib3J0ICAgICAgICAgc2Vjb25k IGhpbnQgaWYgVHJhbnNhY3Rpb25JZERpZEFib3J0KHhtYXgpLAogICAgICAgICAgICAgICAgICAg ICAgICBpbnN0ZWFkIG9mICFJblByb2dyZXNzICYmICFEaWRDb21taXQKICB2MiArIDAwMDEgICAg ICAgICAgICAgc2tpcCB4bWF4ID09IHhtaW4gYW5kIE11bHRpWGFjdCB4bWF4CiAgdjIgKyAwMDAx ICsgMDAwMiAgICAgIDAwMDEsIHRoZW4gVHJhbnNhY3Rpb25JZERpZEFib3J0KHhtYXgpCgpkZWxl dGUuc3FsLCA2NCBob2xkZXJzOgogIGJ1aWxkICAgICAgICAgICAgICAgICAgICBuICBtZWRpYW4g bXMgIHggSEVBRCAgICAgICAgOTUlIENJCiAgSEVBRCAgICAgICAgICAgICAgICAgICAgMTIgICAg ICA0MjQuNCAgICAxLjAwICAgICAgICAgICAgICAKICB2MiAgICAgICAgICAgICAgICAgICAgICAx MiAgICAgIDg0MS4yICAgIDEuOTggICAgMS45Ni4uMi4wMgogIHYyIDFzdCBoaW50IG9ubHkgICAg ICAgIDEyICAgICAgNDIwLjAgICAgMC45OSAgICAwLjk4Li4xLjAxCiAgdjIgKyBza2lwIHhtYXg9 PXhtaW4gICAgMTIgICAgICA0MjQuMiAgICAxLjAwICAgIDAuOTkuLjEuMDEKICB2MiArIHNraXAg eG1heCE9eG1pbiAgICAxMiAgICAgIDgzOC4xICAgIDEuOTggICAgMS45NS4uMi4wNQogIHYyICsg Y2F0YWxvZ3Mgb25seSAgICAgIDEyICAgICAgNDIyLjYgICAgMS4wMCAgICAwLjk5Li4xLjAxCiAg djIgKyBEaWRBYm9ydCAgICAgICAgICAgMTIgICAgICA0MjkuNCAgICAxLjAxICAgIDEuMDAuLjEu MDMKICB2MiArIDAwMDEgICAgICAgICAgICAgICAxMiAgICAgIDQyNC4xICAgIDEuMDAgICAgMC45 OS4uMS4wMgogIHYyICsgMDAwMSArIDAwMDIgICAgICAgIDEyICAgICAgNDIzLjcgICAgMS4wMCAg ICAwLjk4Li4xLjAyCgpzdWJ4YWN0X3VwZGF0ZXMuc3FsLCA2NCBob2xkZXJzOgogIGJ1aWxkICAg ICAgICAgICAgICAgICAgICBuICBtZWRpYW4gbXMgIHggSEVBRCAgICAgICAgOTUlIENJCiAgSEVB RCAgICAgICAgICAgICAgICAgICAgMTIgICAgICA4NzUuMSAgICAxLjAwICAgICAgICAgICAgICAK ICB2MiAgICAgICAgICAgICAgICAgICAgICAxMiAgICAgMTMzOC4zICAgIDEuNTMgICAgMS41MS4u MS41NQogIHYyIDFzdCBoaW50IG9ubHkgICAgICAgIDExICAgICAgODc2LjAgICAgMS4wMCAgICAw Ljk5Li4xLjAxCiAgdjIgKyBza2lwIHhtYXg9PXhtaW4gICAgMTEgICAgIDEzMzUuMCAgICAxLjUz ICAgIDEuNTEuLjEuNTYKICB2MiArIHNraXAgeG1heCE9eG1pbiAgICAxMiAgICAgIDg3Ny43ICAg IDEuMDAgICAgMC45OS4uMS4wMwogIHYyICsgY2F0YWxvZ3Mgb25seSAgICAgIDEyICAgICAgODgy LjEgICAgMS4wMSAgICAxLjAwLi4xLjAzCiAgdjIgKyBEaWRBYm9ydCAgICAgICAgICAgMTEgICAg ICA4ODQuNiAgICAxLjAxICAgIDEuMDAuLjEuMDIKICB2MiArIDAwMDEgICAgICAgICAgICAgICAx MiAgICAgMTMzNi4wICAgIDEuNTMgICAgMS41MS4uMS41NQogIHYyICsgMDAwMSArIDAwMDIgICAg ICAgIDEyICAgICAgODgzLjQgICAgMS4wMSAgICAxLjAwLi4xLjAzCgppbnNlcnRfb25seS5zcWws IDY0IGhvbGRlcnM6CiAgYnVpbGQgICAgICAgICAgICAgICAgICAgIG4gIG1lZGlhbiBtcyAgeCBI RUFEICAgICAgICA5NSUgQ0kKICBIRUFEICAgICAgICAgICAgICAgICAgICAxMiAgICAgIDQxOS42 ICAgIDEuMDAgICAgICAgICAgICAgIAogIHYyICAgICAgICAgICAgICAgICAgICAgIDEyICAgICAg NDE4LjggICAgMS4wMCAgICAwLjk5Li4xLjAxCiAgdjIgMXN0IGhpbnQgb25seSAgICAgICAgMTIg ICAgICA0MTYuMiAgICAwLjk5ICAgIDAuOTguLjEuMDAKICB2MiArIHNraXAgeG1heD09eG1pbiAg ICAxMiAgICAgIDQxNy43ICAgIDEuMDAgICAgMC45OS4uMS4wMQogIHYyICsgc2tpcCB4bWF4IT14 bWluICAgIDEyICAgICAgNDE4LjQgICAgMS4wMCAgICAwLjk5Li4xLjAxCiAgdjIgKyBjYXRhbG9n cyBvbmx5ICAgICAgMTIgICAgICA0MTkuNiAgICAxLjAwICAgIDAuOTkuLjEuMDEKICB2MiArIERp ZEFib3J0ICAgICAgICAgICAxMiAgICAgIDQxOS44ICAgIDEuMDAgICAgMC45OS4uMS4wMQogIHYy ICsgMDAwMSAgICAgICAgICAgICAgIDEyICAgICAgNDE3LjUgICAgMS4wMCAgICAwLjk5Li4xLjAx CiAgdjIgKyAwMDAxICsgMDAwMiAgICAgICAgMTIgICAgICA0MTYuNyAgICAwLjk5ICAgIDAuOTgu LjEuMDEKCnBnX3N0YXRfc2xydSBibGtzX2hpdCtibGtzX3JlYWQgcGVyIFZBQ1VVTSwgZGVsZXRl LnNxbCwgNjQgaG9sZGVyczoKICBidWlsZCAgICAgICAgICAgICAgICAgICAgICAgICAgY2xvZyAg ICAgc3VidHJhbnMKICBIRUFEICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgMCAgICAgICAg ICAgIDAKICB2MiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgMCAgICAgICAgICAgIDAK ICB2MiArIDAwMDEgKyAwMDAyICAgICAgICAgICAgICAgICAgMCAgICAgICAgICAgIDAKCnBnX3N0 YXRfc2xydSBibGtzX2hpdCtibGtzX3JlYWQgcGVyIFZBQ1VVTSwgc3VieGFjdF91cGRhdGVzLnNx bCwgNjQgaG9sZGVyczoKICBidWlsZCAgICAgICAgICAgICAgICAgICAgICAgICAgY2xvZyAgICAg c3VidHJhbnMKICBIRUFEICAgICAgICAgICAgICAgICAgICAgICAgIDQ5OTkzNiAgICAgICA5OTk4 NzIKICB2MiAgICAgICAgICAgICAgICAgICAgICAgICAgIDk5OTg3MiAgICAgIDE5OTk3NDQKICB2 MiArIDAwMDEgKyAwMDAyICAgICAgICAgICAgIDk5OTkzNiAgICAgICA5OTk4NzIKCmRlbGV0ZS5z cWwsIGhvbGRlcnMgc3dlZXAgKG1lZGlhbiBtcywgeCBIRUFEKToKICBob2xkZXJzICAgICBIRUFE ICAgICAgICAgICAgIHYyICAgICAgdjIgKyAwMDAxICAgdjIrMDAwMSswMDAyCiAgICAgICAgMCAg ICAgICAxMiAgICAgIDE3ICgxLjUxKSAgICAgIDEyICgxLjAzKSAgICAgIDEyICgxLjAyKQogICAg ICAgMTYgICAgICAxMTcgICAgIDIyOSAoMS45NSkgICAgIDExOCAoMS4wMSkgICAgIDEyMCAoMS4w MikKICAgICAgIDY0ICAgICAgNDI0ICAgICA4NDEgKDEuOTgpICAgICA0MjQgKDEuMDApICAgICA0 MjQgKDEuMDApCiAgICAgIDEyOCAgICAgIDgyMyAgICAxNjU5ICgyLjAyKSAgICAgODIzICgxLjAw KSAgICAgODM2ICgxLjAxKQoKc3VieGFjdF91cGRhdGVzLnNxbCwgaG9sZGVycyBzd2VlcCAobWVk aWFuIG1zLCB4IEhFQUQpOgogIGhvbGRlcnMgICAgIEhFQUQgICAgICAgICAgICAgdjIgICAgICB2 MiArIDAwMDEgICB2MiswMDAxKzAwMDIKICAgICAgICAwICAgICAgIDUwICAgICAgODMgKDEuNjUp ICAgICAgODMgKDEuNjcpICAgICAgNTcgKDEuMTQpCiAgICAgICAxNiAgICAgIDI2OCAgICAgNDEy ICgxLjU0KSAgICAgNDEyICgxLjU0KSAgICAgMjc2ICgxLjAzKQogICAgICAgNjQgICAgICA4NzUg ICAgMTMzOCAoMS41MykgICAgMTMzNiAoMS41MykgICAgIDg4MyAoMS4wMSkKICAgICAgMTI4ICAg ICAxNzQ4ICAgIDI2NDQgKDEuNTEpICAgIDI2NDUgKDEuNTEpICAgIDE3NTYgKDEuMDApCgpDb3Jy ZWN0bmVzcywgb24gdGhlIHNhbWUgdmFyaWFudHMgYnVpbHQgd2l0aCAtLWVuYWJsZS1jYXNzZXJ0 Ci0tZW5hYmxlLWluamVjdGlvbi1wb2ludHM6CiAgMSAgdjItMDAwMiBpc29sYXRpb24gc3BlYywg Ym90aCBwZXJtdXRhdGlvbnMKICAyICBNaWNoYWVsJ3MgQU5BTFlaRSArIENMVVNURVIgcGdfc3Rh dGlzdGljIHNlcXVlbmNlOiAxIHJvdwogIDMgIFZBQ1VVTSBGVUxMIHBnX2NsYXNzIHdoaWxlIHRo ZSBDUkVBVEUgVEFCTEUgdHJhbnNhY3Rpb24gaXMKICAgICBvcGVuLCBhZnRlciBBTFRFUiBUQUJM RSByb2xsZWQgYmFjayB0byBhIHNhdmVwb2ludDogdGhlCiAgICAgcGdfY2xhc3Mgcm93IHN1cnZp dmVzIHRoZSBDT01NSVQKICA0ICBaaGlqaWUncyBNdWx0aVhhY3QgLyBGT1IgS0VZIFNIQVJFIHJl cHJvIChoaXMgaW5qZWN0aW9uCiAgICAgcG9pbnQgYW5kIHNwZWMpOiBqdWRnZWQgb24gdGhlIGxh c3Qgc3RlcCwgRk9SIFVQREFURSBOT1dBSVQKICAgICBtdXN0IGZhaWwgd2hpbGUgRk9SIEtFWSBT SEFSRSBpcyBoZWxkCiAgNSAgbG9naWNhbCBkZWNvZGluZyAodGVzdF9kZWNvZGluZykgYWNyb3Nz IGNhc2UgMyBwbHVzIGFuCiAgICAgSU5TRVJUOiBib3RoIElOU0VSVHMgZGVjb2RlZCwgbm8gZXJy b3IKICA2ICBtYWtlIGNoZWNrLCBpc29sYXRpb24gY2hlY2ssIHJlY292ZXJ5IDAzNQogIFNhbWUg YXMgMywgdGhlIHBnX2NsYXNzIHJvdyBtdXN0IGV4aXN0IG9uY2Ugd2l0aCB0aGUgcmlnaHQKICBy ZWxuYXR0czoKICA3ICBBTFRFUiBpbiBhIHN1YnRyYW5zYWN0aW9uIHRoYXQgd2FzIHJlbGVhc2Vk CiAgOCAgQUxURVIgaW4gYW4gaW5uZXIgc2F2ZXBvaW50LCByZWxlYXNlZCwgdGhlbiB0aGUgb3V0 ZXIgb25lCiAgICAgcm9sbGVkIGJhY2sKICA5ICBhcyAzLCB0aGVuIFBSRVBBUkUgVFJBTlNBQ1RJ T04gYmVmb3JlIHRoZSBWQUNVVU0gRlVMTAogIDEwIGFzIDcsIHRoZW4gUFJFUEFSRSBUUkFOU0FD VElPTiBiZWZvcmUgdGhlIFZBQ1VVTSBGVUxMCiAgMTEgb25lIEFMVEVSIHJlbGVhc2VkLCB0aGVu IGEgc2Vjb25kIEFMVEVSIHJvbGxlZCBiYWNrCgogIGJ1aWxkICAgICAgICAgICAgICAgICAxIDIg MyA0IDUgNiA3IDggOSAxMCAxMQogIEhFQUQgICAgICAgICAgICAgICAgICBGIEYgRiAuIEYgLiAu IEYgRiAuICBGCiAgdjIgICAgICAgICAgICAgICAgICAgIC4gLiAuIEYgLiAuIC4gLiAuIC4gIC4K ICB2MiAxc3QgaGludCBvbmx5ICAgICAgRiAuIEYgLiBGIC4gLiBGIEYgLiAgRgogIHYyICsgc2tp cCB4bWF4PT14bWluICAuIC4gLiBGIC4gLiAuIC4gLiAuICAuCiAgdjIgKyBza2lwIHhtYXghPXht aW4gIEYgLiBGIC4gRiAuIC4gRiBGIC4gIEYKICB2MiArIGNhdGFsb2dzIG9ubHkgICAgLiAuIC4g KiAuIC4gLiAuIC4gLiAgLgogIHYyICsgRGlkQWJvcnQgICAgICAgICAuIC4gLiBGIC4gLiAuIC4g LiAuICAuCiAgdjIgKyAwMDAxICAgICAgICAgICAgIC4gLiAuIC4gLiAuIC4gLiAuIC4gIC4KICB2 MiArIDAwMDEgKyAwMDAyICAgICAgLiAuIC4gLiAuIC4gLiAuIC4gLiAgLgogICguIHBhc3MsIEYg ZmFpbCkKICAqIHBhc3NlcyBvbmx5IGJlY2F1c2UgdGhlIHJlcHJvIHRhYmxlIGlzIG5vdCBhIGNh dGFsb2csIHNvIHRoZQogICAgbmV3IGNvZGUgaXMgbmV2ZXIgcmVhY2hlZDsgb24gYSBjYXRhbG9n IGl0IGtlZXBzIHYyJ3MgcmFjZS4KCiAgTXV0YW50IGNoZWNrOiAwMDAxICsgMDAwMiB3aXRoIHRo ZSBoaW50IHNldCB1bmNvbmRpdGlvbmFsbHkKICBwYXNzZXMgY2FzZXMgMiwgMyBhbmQgNSwgYW5k IGZhaWxzIDcsIDEwIGFuZCAxMSB3aXRoIHR3bwogIHBnX2NsYXNzIHJvd3MgZm9yIHRoZSB0YWJs ZSAob2xkIGFuZCBuZXcgdmVyc2lvbiBib3RoIGtlcHQpLgo= --===============3810972130029512734== Content-Type: text/plain Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="nocfbot-0001-skip-equal-xmax-and-multi-on-v2.diff.txt" MIME-Version: 1.0 QXBwbGllcyBvbiB0b3Agb2YgdjItMDAwMSBhbmQgdjItMDAwMiB1cHRocmVhZC4gIE5vdCBmb3Ig dGhlIENGIGJvdC4KU2tpcCB4bWF4ID09IHhtaW4gYW5kIE11bHRpWGFjdCB4bWF4IGluIHRoZSBz ZWNvbmQgaGludC4KCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9hY2Nlc3MvaGVhcC9oZWFwYW1f dmlzaWJpbGl0eS5jIGIvc3JjL2JhY2tlbmQvYWNjZXNzL2hlYXAvaGVhcGFtX3Zpc2liaWxpdHku YwotLS0gYS9zcmMvYmFja2VuZC9hY2Nlc3MvaGVhcC9oZWFwYW1fdmlzaWJpbGl0eS5jCisrKyBi L3NyYy9iYWNrZW5kL2FjY2Vzcy9oZWFwL2hlYXBhbV92aXNpYmlsaXR5LmMKQEAgLTExOTEsMTIg KzExOTEsMTUgQEAgSGVhcFR1cGxlU2F0aXNmaWVzVmFjdXVtSG9yaXpvbihIZWFwVHVwbGUgaHR1 cCwgQnVmZmVyIGJ1ZmZlciwgVHJhbnNhY3Rpb25JZCAqZGUKIAkJCSAqIGZyb20gYW4gdXBkYXRl ZCBvbmUuCiAJCQkgKi8KIAkJCWlmICghKHR1cGxlLT50X2luZm9tYXNrICYgSEVBUF9YTUFYX0lO VkFMSUQpICYmCisJCQkJISh0dXBsZS0+dF9pbmZvbWFzayAmIEhFQVBfWE1BWF9JU19NVUxUSSkg JiYKIAkJCQkhSEVBUF9YTUFYX0lTX0xPQ0tFRF9PTkxZKHR1cGxlLT50X2luZm9tYXNrKSAmJgog CQkJCSFIZWFwVHVwbGVIZWFkZXJJc09ubHlMb2NrZWQodHVwbGUpKQogCQkJewogCQkJCVRyYW5z YWN0aW9uSWQgeG1heCA9IEhlYXBUdXBsZUhlYWRlckdldFVwZGF0ZVhpZCh0dXBsZSk7CiAKLQkJ CQlpZiAoIVRyYW5zYWN0aW9uSWRJc0luUHJvZ3Jlc3MoeG1heCkgJiYKKwkJCQkvKiB4bWF4ID09 IHhtaW46IHhtYXggaXMgaW4gcHJvZ3Jlc3MgdG9vLCBub3RoaW5nIHRvIGRvICovCisJCQkJaWYg KCFUcmFuc2FjdGlvbklkRXF1YWxzKHhtYXgsIEhlYXBUdXBsZUhlYWRlckdldFJhd1htaW4odHVw bGUpKSAmJgorCQkJCQkhVHJhbnNhY3Rpb25JZElzSW5Qcm9ncmVzcyh4bWF4KSAmJgogCQkJCQkh VHJhbnNhY3Rpb25JZERpZENvbW1pdCh4bWF4KSkKIAkJCQkJU2V0SGludEJpdHModHVwbGUsIGJ1 ZmZlciwgSEVBUF9YTUFYX0lOVkFMSUQsCiAJCQkJCQkJCUludmFsaWRUcmFuc2FjdGlvbklkKTsK --===============3810972130029512734== Content-Type: text/plain Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="nocfbot-0002-clog-only-abort-check-on-v2.diff.txt" MIME-Version: 1.0 QXBwbGllcyBvbiB0b3Agb2YgdjIgYW5kIG5vY2Zib3QtMDAwMS4gIE5vdCBmb3IgdGhlIENGIGJv dC4KQXNrIHRoZSBjbG9nIG9ubHk6IFRyYW5zYWN0aW9uSWREaWRBYm9ydCgpIG9uIHhtYXguCgpk aWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvYWNjZXNzL2hlYXAvaGVhcGFtX3Zpc2liaWxpdHkuYyBi L3NyYy9iYWNrZW5kL2FjY2Vzcy9oZWFwL2hlYXBhbV92aXNpYmlsaXR5LmMKLS0tIGEvc3JjL2Jh Y2tlbmQvYWNjZXNzL2hlYXAvaGVhcGFtX3Zpc2liaWxpdHkuYworKysgYi9zcmMvYmFja2VuZC9h Y2Nlc3MvaGVhcC9oZWFwYW1fdmlzaWJpbGl0eS5jCkBAIC0xMTk3LDEwICsxMTk3LDE1IEBAIEhl YXBUdXBsZVNhdGlzZmllc1ZhY3V1bUhvcml6b24oSGVhcFR1cGxlIGh0dXAsIEJ1ZmZlciBidWZm ZXIsIFRyYW5zYWN0aW9uSWQgKmRlCiAJCQl7CiAJCQkJVHJhbnNhY3Rpb25JZCB4bWF4ID0gSGVh cFR1cGxlSGVhZGVyR2V0VXBkYXRlWGlkKHR1cGxlKTsKIAotCQkJCS8qIHhtYXggPT0geG1pbjog eG1heCBpcyBpbiBwcm9ncmVzcyB0b28sIG5vdGhpbmcgdG8gZG8gKi8KKwkJCQkvKgorCQkJCSAq IHhtaW4gaXMgaW4gcHJvZ3Jlc3MsIHNvIHhtYXggaXMgaW4gdGhlIGluc2VydGVyJ3MKKwkJCQkg KiB0cmFuc2FjdGlvbiB0cmVlLiAgSWYgeG1heCA9PSB4bWluLCBpdCBpcyBpbiBwcm9ncmVzcwor CQkJCSAqIHRvby4gIE90aGVyd2lzZSBpdCBpcyBydW5uaW5nIG9yIGl0IGlzIGEgc3VidHJhbnNh Y3Rpb24KKwkJCQkgKiB0aGF0IGFib3J0ZWQsIGFuZCB0aGUgYWJvcnQgcmVhY2hlcyB0aGUgY2xv ZyBiZWZvcmUgdGhlCisJCQkJICogc3VidHJhbnNhY3Rpb24gbGVhdmVzIHRoZSBwcm9jIGFycmF5 OiB0aGUgY2xvZyB0ZWxscy4KKwkJCQkgKi8KIAkJCQlpZiAoIVRyYW5zYWN0aW9uSWRFcXVhbHMo eG1heCwgSGVhcFR1cGxlSGVhZGVyR2V0UmF3WG1pbih0dXBsZSkpICYmCi0JCQkJCSFUcmFuc2Fj dGlvbklkSXNJblByb2dyZXNzKHhtYXgpICYmCi0JCQkJCSFUcmFuc2FjdGlvbklkRGlkQ29tbWl0 KHhtYXgpKQorCQkJCQlUcmFuc2FjdGlvbklkRGlkQWJvcnQoeG1heCkpCiAJCQkJCVNldEhpbnRC aXRzKHR1cGxlLCBidWZmZXIsIEhFQVBfWE1BWF9JTlZBTElELAogCQkJCQkJCQlJbnZhbGlkVHJh bnNhY3Rpb25JZCk7CiAJCQl9Cg== --===============3810972130029512734==--