Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qFJTg-0002w8-Tb for pgsql-bugs@arkaria.postgresql.org; Fri, 30 Jun 2023 19:08:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qFJTe-0006Pc-K0 for pgsql-bugs@arkaria.postgresql.org; Fri, 30 Jun 2023 19:08:18 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qFJTe-0006PT-C7 for pgsql-bugs@lists.postgresql.org; Fri, 30 Jun 2023 19:08:18 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qFJTX-001QfW-3g for pgsql-bugs@lists.postgresql.org; Fri, 30 Jun 2023 19:08:17 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 35UJ85fQ1800419; Fri, 30 Jun 2023 15:08:05 -0400 From: Tom Lane To: Andrew Dunstan cc: Andres Freund , exclusion@gmail.com, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #17994: Invalidating relcache corrupts tupDesc inside ExecEvalFieldStoreDeForm() In-reply-to: References: <17994-5c7100b51b4790e9@postgresql.org> <1306569.1687978174@sss.pgh.pa.us> <20230628194446.uu47f4vyfyjfl7dd@awork3.anarazel.de> <1314841.1687981948@sss.pgh.pa.us> <20230628205443.6gu5bmcck6t4pgyv@awork3.anarazel.de> <1509402.1688048784@sss.pgh.pa.us> <7ae37634-7626-8977-4d89-20603f0d1dcf@dunslane.net> <1583514.1688066735@sss.pgh.pa.us> <326723ee-ee05-35bf-06fd-e4f3afc61654@dunslane.net> <1610276.1688078516@sss.pgh.pa.us> <5316ba5d-ab3b-4ae2-6f6b-f22760932d99@dunslane.net> <1742513.1688129204@sss.pgh.pa.us> <1749275.1688132604@sss.pgh.pa.us> Comments: In-reply-to Andrew Dunstan message dated "Fri, 30 Jun 2023 14:43:20 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1800417.1688152085.1@sss.pgh.pa.us> Date: Fri, 30 Jun 2023 15:08:05 -0400 Message-ID: <1800418.1688152085@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andrew Dunstan writes: > Me either. I think this might call for too much invention so I'm going > to revert to plan A. The invalidation code won't be very much, and it > should be a fairly rare event, so it doesn't need to be very clever. The problem with rarely-executed code is that it's also hard to test. regards, tom lane